Not sure whether this really is a bug report or wanted behavior but when using Bartik as an admin theme, text written in body textarea (and other textareas added to the content type) is displayed with a 115% font-size. It looks kinda wrong to me.

There is another styling problem on that same page, which you can see in my second screenshot. Let me know if these are actual issues and I will propose a patch.

CommentFileSizeAuthor
#9 847118-9.patch582 bytesreglogge
#8 847118-8.patch584 bytesreglogge
#6 847118.patch1.05 KBaschiwi
#3 drupal-bartik-847118.patch1.14 KBaschiwi
#2 drupal-bartik-issue-847118.patch896 bytesaschiwi
styling issue33.21 KBaschiwi
textarea120.9 KBaschiwi

Comments

jensimmons’s picture

jensimmons commented
Status: Needs work » Active

Yes, it would be good to fix these bugs. I don't think there was any intention to make the text area font be so large.

Embedding screenshots for easy viewing:

aschiwi’s picture

aschiwi commented
Title: Bartik as admin theme » Two tweaks needed for using Bartik as admin theme
Priority: Normal » Minor
Status: Active » Needs review
StatusFileSize
new drupal-bartik-issue-847118.patch896 bytes

The actual problem for the big font issue is this line (#431) in style.css

#block-system-main, #preview #preview-block-system-main {
font-size:115%;
line-height:1.5em;
}

It makes everything on node/add/* look kinda bad. Not sure what it is needed for but those pages look better without the 115% font-size. It might be a good idea to use a body class to overwrite that part.

I was able to narrow down the second problem to the .filter-wrapper fieldset. Any field (I guess it's any field, tried with textfield and textarea) displayed right below it gets its label hidden behind it. Plus it seems detached from the body field (see screenshot http://drupal.org/files/issues/bartik_admin_2.jpg). The culprit is the fieldset declaration on line 930 of style.css. My suggestion is to add something like 

body.page-node-add fieldset {
  top: 0;
}

Adding 0 margin and padding to fieldset-wrapper in body.page-node-add also does a lot to make that page prettier.

I feel like this might be a good solution so I'm making this a patch. This is only like my 3rd or 4th patch and my first patch for core so please be kind if I totally messed it up :)

aschiwi’s picture

aschiwi commented
StatusFileSize
new drupal-bartik-847118.patch1.14 KB

For some reason I forgot to add the fix for the textarea font-size. New patch attached.

Status: Needs review » Needs work

The last submitted patch, drupal-bartik-847118.patch, failed testing.

aschiwi’s picture

aschiwi commented

Could somebody please quickly check my approach before I re-roll the patch? Will re-roll tomorrow.

aschiwi’s picture

aschiwi commented
Status: Active » Needs review
StatusFileSize
new 847118.patch1.05 KB

Trying again.

beasley’s picture

beasley commented

Just a comment on the text size issue. I think the patch will only work when you are creating a new node because then the body will have a class of 'page-node-add'. Once you've created the node and you go back to edit it then the class won't be applied - 'page-node-edit' is applied instead. So if you edit an existing article the text will revert to being big again.

The simplest solution might be to just add the font size where the font stack is declared i.e line 81 in style.css:

input, textarea, select, a.button {
font-family:"Lucida Grande","Lucida Sans Unicode",Verdana,sans-serif;
font-size:95%;
line-height: 1.5;
}

I've added a larger line-height, too, because there is virtually no leading when the text goes smaller. This works for me and keeps the text size consistent across all the form boxes that I've come across.

reglogge’s picture

reglogge commented
StatusFileSize
new 847118-8.patch584 bytes

@beasley: You are right, it is much better to generalize this on textarea everywhere (the same issue with too large text appears in the comment form, for example).

The fix should only apply to textarea and input though, because select would become too big with your method. The font-size for a.button is set in a dedicated style anyway.

Patch attached.

reglogge’s picture

reglogge commented
StatusFileSize
new 847118-9.patch582 bytes

sorry, empty line in #8.

reglogge’s picture

reglogge commented
Title: Two tweaks needed for using Bartik as admin theme » Text in textareas rendered too big in Firefox
Priority: Minor » Normal

Changed the title to more accurately reflect the actual issue. This effect doesn't appear in Chrome, Safari or IE since they have different setting in their user agent stylesheets for textarea than Firefox. So we need to explicitly declare the font-size here.

Jeff Burnz’s picture

Jeff Burnz commented
Title: Text in textareas rendered too big in Firefox » Two tweaks needed for using Bartik as admin theme
Status: Needs review » Closed (duplicate)

Font sizes are now being fixed here all in one hit, since its hard to keep re-rolling each time these small patches get committed: #660614: Remove #block-system-main dependency, fix font sizes, remove crufty CSS

Please help out there, we really need your help to improve the patch in #660614