Cache mollom_form_load() and query in mollom_form_alter()

#717874: Provide exportables for Mollom forms also touches those code lines. Not sure which one I'm going to tackle in-depth first.

Clearing would only have to happen after submission of Mollom's own administrative forms, I think. Unless those are submitted, the protected forms and their configuration should be the same as before.

--

However, I again have this issue here (as in some other core patch)... we are replacing a query with a query here, no? - oh, kkk... you want to prefetch or cache it away in memcached or whatnot, I understand ♥

Does that warrant a code comment? :)

queuing to run tests.

We need to cache a little more for mollom_form_alter(), because there's a second form alter happening for delete confirmation forms. So while this patch catched the list of protected forms and mollom_form_load(), it still resulted in a second cache lookup for the delete confirmation form mapping.

Attached patch re-implements caching to account for all of that. It should result in 1 cache lookup for a unprotected form, and an additional lookup for every protected form.

White-space hiccup.

hah, nice. Learned something new about my code. :)

Works! :)

+++ mollom.module	13 Sep 2010 22:46:05 -0000
@@ -551,7 +551,7 @@ function mollom_data_report_multiple($en
+  $forms = &drupal_static(__FUNCTION__);

@@ -563,8 +563,13 @@ function mollom_form_alter(&$form, &$for
+  if (!isset($cache)) {

err, oopsie. :-|

+++ mollom.module	13 Sep 2010 22:46:05 -0000
@@ -563,8 +563,13 @@ function mollom_form_alter(&$form, &$for
+  if (variable_get('mollom_testing_mode', 0) && empty($_POST) && (isset($forms['protected'][$form_id]) || strpos($_GET['q'], 'admin/config/content/mollom') === 0)) {

This will still output multiple warnings, in case we alter multiple protected forms on a single page.

Powered by Dreditor.

Fixed #11.

Committed to CVS HEAD. Thanks.

So this would be the cleaner variant.

Cumulative backport to D6.

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

One more tiny tweak -- we don't need to invoke all hook_mollom_form_list() implementations in mollom_form_load(), as we already know from which module to retrieve the data.

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.