If the toolbar doesn't have the IE shadow filter applied, or the toolbar is not in the DOM for some reason we get the following error:

$("#toolbar").css("filter") is undefined

CommentFileSizeAuthor
#2 toolbar_js_v2.patch1.01 KBaspilicious
toolbar-filters.patch1.09 KBcasey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, toolbar-filters.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
toolbar_js_v2.patch1.01 KB

Here is a reroll

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
casey’s picture

casey CreditAttribution: casey commented

Thanks (I am having problems with my IDE and was trying out another one).

casey’s picture

casey CreditAttribution: casey commented

#2: toolbar_js_v2.patch queued for re-testing.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Needs review » Needs work

Patch no longer applies.

The issue summary states that we want to avoid errors if #toolbar is not in the DOM for some reason, but the patch in #2 doesn't seem to address that, as it checks $toolbar[0].filters; $toolbar.length might be more appropriate here.

See http://jsfiddle.net/uA9zE/ for an example of the error I'd expect to see if #2 was re-rolled.

This code doesn't seem to exist any more in D8, so I'm not sure if it's a problem any more there.

Review bonus #2094585: [policy, no patch] Core review bonus for #1898420: image.module - Convert theme_ functions to Twig.