Pass full node to implementations of hook_mailhandler_post_save

Subscribe. Thanks for all the hard work, Dane!

subscribe

I'd say this patch is way too much
you already have the $nid, if you want the $node do your own node_load

why do you need to be fed?

it doesn't bothered me the first time I read this patch
but today it yelled at me

now I re-read the comment:
// Pass in the $nid (which could be a $cid, depending on $node->type)

so, having an Id wouldn't tell you if it is a cid or nid
and the $node variable is not a comment neither a node, rather the comment/email object

wow, it seems that this module could use some cleanup and commented code
but not your issue

BTW, maintainers we mean no harm, it's just that we are dealing with it and we get lost
PS: I'm sure that by "inaptly" Dane meant "inappropriately" rather than "incompetently"

@Dane, just wanted to let you know I see this thread and I should get around to the queue next week. WRT the scope of mailhandler, I agree it needs to be cut back. I started Mailhandler 2.x awhile ago and it's getting close to alpha http://github.com/ianshward/Mailhandler-2.0 ... it leans on the Feeds module framework, with the base module just handling parsing an IMAP stream. You can then write a processor which takes the parsed message information and does something with it, like create nodes. The node-centricity is completely broken out from the base mailhandler module and lives in a mailhandler_node module which implements its own node/comment processor. You can also write custom command parsing plugins, etc. This should make its way back into Drupal CVS soon http://github.com/ianshward/Mailhandler-2.0

Attached is a patch which changes the name of the misleading $nid param and adds a comment about what's going on. I figured we may as well take this opportunity to improve that $nid param name. I couldn't think of anything better than $saved. But, I agree that $nid is confusing, and $id doesn't make sense either since it's sometimes an object.

I just marked #801992: $nid in hook_mailhandler_post_after as a dupe of this.

I would prefer the first parameter to be an $id (whether cid or nid)
$type will make the distinction and the original $node object will be passed anyway
but I guess backward compatibility must be preserved, sigh

BTW patch at #10 is too short, $saved is not even initialized (and I'm not clear about what's in $node at that point)

  if ($node) {
    if ($node->type == 'comment') {
      $nid = mailhandler_comment_submit($node, $header, $mailbox, $origbody);
      $type = 'comment';
    }
    else {
      $nid = mailhandler_node_submit($node, $header, $mailbox, $origbody);
      $type = 'node';
    }
  }

@arhak thanks for the review. Here's an updated patch. I agree about the backwards compatibility.