Multiple copies of same invoice are display in Invoice View

Re-attaching screenshot.

Thanks tchurch for trying to reproduce :) I'll try to reproduce again from my end. Then post results here.

I think you'll find that the two entries point to two different node_id's.
Can you confirm this?

Thanks for your reply. Nope. All the invoices you see in screeshoot from #2 point to the same node_id. For a total of 4 invoices display in the view. But all 4 links point to the same node_id. In other words there is only one invoice. Every time I edit the invoice a new view is added to the view list.

Also this bug wasn't present before I applied the patch. But appear after I applied the patch. I'm referring to this patch http://drupal.org/node/817322#comment-3053184

Full module 1.33 with patch already applied http://drupal.org/node/817322#comment-3214760

I tested this issue on a fresh Drupal 6.16 install with Storm 1.33 and was not able to reproduce.

Issue was detected on a production site. After applying following patch to 1.33 http://drupal.org/node/817322#comment-3214760

I'll do another test with a fresh install then post my result here.

Note to self: The following removed some of the duplicates display in Invoice View at /storm/invoices
1. Go to admin/settings/performance
2. Deactivate all Drupal core caches
3. Save settings
4. Go again to admin/settings/performance
5. Click on 'Clear cached data'

I can confirm that applying the following patch to 1.33 create this issue. I'm referring to this patch http://drupal.org/node/817322#comment-3053184

The following attached file creates the issue. This is the file after applying patch: storminvoice.module(after-patch).tar_.gz

The following attached file doesn't create issue. This is the file before applying the patch: storminvoice.module(before-patch).tar_.gz

I'm not a coder so I can't tell which line(s) into the file are the source of the issue. But storminvoice.module(after-patch).tar_.gz is definitely link to this issue.

I found another source of the issue. That one was hard to find. Very deep. I had to put on a scuba diving suit and bring a few extra bottles of air with me ;)

New steps the reproduce issue. Note that step 3 is the most important step.
1. One of the two following

2. Go to admin/content/node-type/storminvoice
3. Expand Workflow settings. Check Create new revision box.
2. Go to /storm/invoices Add an invoice.
3. Edit above invoice 3 times. For example change the invoice number or the description field.
4. Go to /storm/invoices to view the list of invoices. Multiple copies of same invoice are display. Notice that they all link to the same node_id/URL. This is the issue. Find attached screenshot to clarify issue location.
5. Expected result is to display only one copy of the same invoice. The most up-to-date one not all the invoice 'revisions'.

Reproduced with:
*Drupal 6.16 Fresh install
*Storm 6.x-1.33 / Storm dev 6.x-1.x-dev July 11, 2010 / Storm 6.x-1.33 with Patch

Note to self: Attaching Storm dev 6.x-1.x-dev July 11, 2010

Thanks tchurch :)

We should look at fixing the revision problem with this issue (in the dev version)

Ok. Changing version to 6.x-1.x-dev then.

I would be happy to contribute testing for a new patch. Any volunteers for a patch?

Thanks juliangb

See previous issues (a while ago) which also had trouble with revisions.

I didn't apply the patch properly before. It works for me now. RTBC from me, but Francewhoa, can you confirm too?

Sure. Confirming issue is fixed in latest Storm version. No more duplicates. Thanks all :)