help column on modules page appears even when help module is disabled

I noticed this, too. Patch works for me and looks good. Nice catch.

Powered by Dreditor.

+++ modules/system/system.admin.inc	17 Jul 2010 18:54:56 -0000
@@ -946,12 +946,13 @@ function system_modules($form, $form_sta
+      '#help_arg' => $help_arg,

#help_arg is a bit ugly. Any reason it can't be just #help?

+++ modules/system/system.admin.inc	8 Sep 2010 04:36:36 -0000
@@ -952,12 +952,13 @@ function system_modules($form, $form_sta
-        array('data' => t('Operations'), 'colspan' => 3),
+        array('data' => t('Operations'), 'colspan' => $help_arg ? 3 : 2),

@@ -2632,6 +2633,9 @@ function theme_system_modules_fieldset($
+      if (!$form['#help'] && $key == 'help') {
+        continue;
+      }

While this is a good bug fix, the changes introduced by this patch look a bit odd for casual code readers.

Can we add an inline comment to both locations I pasted?

Powered by Dreditor.