tabs go half-active when below them [#860136]

At a page like admin/structure/types/manage/article/fields, the 'Manage fields' tab looks active: it's white, and it has no bottom border.

One page down, at admin/structure/types/manage/article/fields/field_image/field-settings, it's half-active: greyed out, BUT still has no bottom border.

Whereas on Garland, the tab looks the same on both pages.

Is this normal?

Comment	File	Size	Author
#12	bartik-fixed-ie-rtl.png	5.88 KB	aspilicious
#11	bartik-ie6-7-active-tab-padding.png	6.95 KB	Jeff Burnz
#11	bartik-active-tabs-fix-860136.patch	2.41 KB	Jeff Burnz
#9	bartik-fixed.png	19.82 KB	aspilicious
#8	tabs-fix.patch	1.44 KB	aspilicious
#1	bartik_fix_colors_active_tabs.patch	1.5 KB	aspilicious
	drupal-bartik-tabs-active.png	56.91 KB	joachim

Comments

Comment #1

aspilicious commented 22 July 2010 at 08:14

Status	File	Size
new	bartik_fix_colors_active_tabs.patch	1.5 KB

Gotzz a patch!

Fixed also the issue that the border between the active tab and the background always was white. Very ugly if you choose darker colours as background.
(BTW: i suggest never use an other colour than white cause the unactive tabs are always grey and the text always keep black)

Comment #2

aspilicious commented 22 July 2010 at 08:14

Status:

Active

» Needs review

Comment #3

Jeff Burnz commented 17 August 2010 at 17:42

Status:

Needs review

» Needs work

+++ themes/bartik/css/style.css	22 Jul 2010 07:52:28 -0000
@@ -773,8 +773,9 @@
+.tabs ul.primary li a.active,

Why do we need this selector - seems redundant.

Powered by Dreditor.

Comment #4

aspilicious commented 17 August 2010 at 18:48

Has been a while...

1) There were differences between the tabs on nodes and the tabs on manage fields. (can't remember exactly, srry)
2) Colors.css defines this

.tabs ul.primary li a.active,
.tabs ul.primary li.active a {
  background-color: #ffffff;
}

So we need to override both selectors.

*** trying to find the difference ***

Comment #5

Jeff Burnz commented 17 August 2010 at 21:19

Looking at theme_menu_local_task it looks to me like the li will always get the active class if its active, however the anchor may get it if its in localized_options (is some cases it does not).

return '<li' . (!empty($variables['element']['#active']) ? ' class="active"' : '') . '>' . l($link_text, $link['href'], $link['localized_options']) . "</li>\

So it would seem the only selector we actually require is .tabs ul.primary li.active a and never both.