mm_s3 calls dl() in hook_requirements, dl() is disabled in PHP 5.3 [#863896]

(This is also an issue for 6.x-2.x-dev, but you can only select one release)

On line 8 of media_mover/contrib/mm_s3/mm_s3.install, there's the following check:

if (extension_loaded('curl') && !@dl(PHP_SHLIB_SUFFIX == 'so' ? 'curl.so' : 'php_curl.dll')) { $has_curl = true; }

This causes a particularly nasty WSOD in PHP 5.3: dl() is deprecated, and in many installs, completely missing. The error suppression on dl() causes a silent WSOD with no errors anywhere.

I'm not sure why mm_s3 even calls dl(): shouldn't extension_loaded('curl') be sufficient? Attached are two patches (one for 6.x-1.x-dev and one for 6.x-2.x-dev) that removes the dl() call and rewrites the check to conform to Drupal coding standards.

Comment	File	Size	Author
#3	mm_s3_6.x-1-dev.install.patch	1.64 KB	RobinMofo
#3
#2	mm_s3-php53-drupal-6--1.patch	883 bytes	Mark Trapp
#2
#2	mm_s3-php53-drupal-6--2.patch	879 bytes	Mark Trapp
#2
	mm_s3-php53-drupal-6--2.patch	894 bytes	Mark Trapp

	mm_s3-php53-drupal-6--1.patch	898 bytes	Mark Trapp

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Mark Trapp

he/him

English

CreditAttribution: Mark Trapp commented 25 July 2010 at 01:41

Title:

mm_s3 calls dl() in hook_requirements, dl() is removed in PHP 5.3

» mm_s3 calls dl() in hook_requirements, dl() is disabled in PHP 5.3

Update to more accurate title. It's not actually removed, it's just disabled unless explicitly enabled except for certain SAPIs.

According to the Changelog, it was deprecated and disabled for stability issues, and the recommended workaround is to use extension loading directives instead of dynamically loading an extension at runtime: http://php.net/manual/en/function.dl.php

Comment #2

Mark Trapp

he/him

English

CreditAttribution: Mark Trapp commented 25 July 2010 at 01:50

File	Size
mm_s3-php53-drupal-6--2.patch	879 bytes

mm_s3-php53-drupal-6--1.patch	883 bytes

One last comment, I swear. Now that dl() is removed, there's no need to perform logic on extension_loaded: it returns TRUE or FALSE. Rerolled patches.

Comment #3

RobinMofo CreditAttribution: RobinMofo commented 20 October 2010 at 10:51

File	Size
mm_s3_6.x-1-dev.install.patch	1.64 KB

Sorry I'm going to add my two cents and include the use of get_t() function as specified in the hook_requirements API.

Hopefully this can be added to DEV soonish as I didn't see your issue before I started investigating the cause!

Comment #4

arthurf CreditAttribution: arthurf commented 20 October 2010 at 17:04

I committed a slightly different version of these patches. Please let me know if it works for you

Comment #5

mjvesper CreditAttribution: mjvesper commented 10 November 2010 at 08:13

Running PHP 5.3 and tried the Oct 20, 2010 Dev release. Still get a WSOD when saving S3 settings.

Comment #6

mjvesper CreditAttribution: mjvesper commented 15 November 2010 at 05:53

Status:

Needs review

» Needs work

Guess I should change the status?

Comment #7

arthurf CreditAttribution: arthurf commented 16 November 2010 at 23:46

Status:

Needs work

» Active

@mjvesper can you provide the actual error you're getting?

[Sat Nov 20 13:29:23 2010] [error] [client xxx.xxx.xxx.xxx] PHP Fatal error:  Call to undefined method S3::checkKeys() in /home/[path]/sites/all/modules/media_mover/contrib/mm_s3/mm_s3.module on line 141, referer: https://[path]/admin/build/media_mover/settings/mm_s3

So not dl() I guess, but still a WSOD.