Closed (fixed)
Project:
Privatemsg
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
26 Jul 2010 at 02:39 UTC
Updated:
5 Nov 2010 at 09:00 UTC
Jump to comment: Most recent file
I add settings to control the displays of input format selection and preview button in the patch.
The form to compose new message hides input format selection and preview button by default for better usability for common users.
| Comment | File | Size | Author |
|---|---|---|---|
| #19 | format_preview_backport_2.patch | 5.41 KB | berdir |
| #17 | format_permission_preview_setting_6.patch | 4.63 KB | berdir |
| #16 | format_permission_preview_setting_d6.patch | 4.63 KB | berdir |
| #13 | format_permission_preview_setting4.patch | 6.75 KB | berdir |
| #11 | format_permission_preview_setting3.patch | 6.76 KB | berdir |
Comments
Comment #1
berdirInteresting, thanks for the patch.
However, new features are only added to the 2.x branch, can you re-roll?
Also, at least the format setting could also be a permission or somehow else role-dependant. Even though "normal" users should not see it, the site admin might for some reason want to send messages that need another format.
Always set issues with patches to needs review, then they are tested (this is going to fail because it's against 1.x)
Comment #3
shenzhuxi commentedPatch to 2.x
Role based permission to select input format
Comment #5
berdirYou probably need to make the patch against CVS, inside the privatemsg directory, or it is not going to apply. http://drupal.org/node/3279/cvs-instructions/HEAD has copy & paste commands to do the CVS checkout and create a patch.
- Not sure about the permission name, that should imho somehow contain the information that this only affects privatemsg (and also avoid conflicts with other modules). "use input format for private messages"?
- Thinking about an update function to give the permission to all roles that have the write privatemsg permission. Reason is, just adding the pemission would change the behaviour when users upgrade to the latest release. We have done this when introducing the delete permission, see http://blog.worldempire.ch/de/api/function/privatemsg_update_6005/1. On the other side, this is a -dev release and things *are* changing while the delete permission was added late in the development cycle of the 1.x branch.
- Just as a reminder, when porting this to D7: Drupal has changed "input format" to "text format", we probably need to rename the permission there. D7 has a separate table for permissions, so that should be easier than the REPLACE() hack we need in D6.
Comment #6
BenK commentedIf we have a patch that passes automated testing, I can help test it manually....
--Ben
Comment #7
BenK commentedBumping this to the top of priority list so that we can deal with this at the same time as the CSS fixes to the message view page. Also changing version to 7.x.
--Ben
Comment #8
berdirOk, here is your patch :)
Comment #9
berdirThis should pass the tests.
Comment #11
berdirNext try.
Comment #13
berdirMaybe this one?
Comment #14
BenK commentedThis patch is working great. Tested it a bunch of ways and no problems at all. All functionality is working as advertised and the text strings look good. And it definitely helps streamline and simplify the page. This is RTBC.
Thanks!
--Ben
Comment #15
berdirCommitted, will do a backport of this later on.
Comment #16
berdirAnd here is a backport for this one...
Comment #17
berdirSame patch without d6 suffix.
Comment #19
berdirNew patch, should fix the test fails.
Comment #20
berdirCommited.
Comment #21
berdir