enable module / theme

Drush make is specifically for packaging modules together, not for doing anything beyond that

Well, the project page description begins "Drush make is an extension to drush that can create a ready-to-use drupal site." That means that if my site isn't ready to use, then drush_make is not working as designed, and this issue should be reopened. And if modules aren't enabled, then my site isn't ready to use. Unless having to run an install profile and then enable all the modules I just downloaded by hand counts as "site use" in the sense that my mother would understand it, and I've asked my mother and she says no.

Right now this focus on just doing downloads and nothing else is limiting "drush make" to being something like "drush automate some downloads with URL parsing and recursion." That's a handy set of tasks to automate, but it stops short of being a proper makefile parser in the C sense, which I think is what people expect and want. That means that it's also unlikely to be adopted by people who are already part-way through a site build process, or have had a site for two years and now want to use drush makefiles for e.g. packaging features (or who can just fudge this stuff with bash and wget.) It's also a question of user expectation, when the project page promises a "ready-to-use site" and all they get is a bunch of downloads.

Please find attached: 1. a patch which lets drush make handle module enabling and other arbitrary drush commands and 2. a makefile which implements the functionality. The new drush command that the patch provides is called drush make-and-go.

This patch is not perfect: you have to run the code as

% drush make-and-go /absolute/path/to/makefile/test.make

Otherwise for some reason it can't find the makefile. Also, even if you're in an existing Drupal site, it installs all downloads in sites/all/.../ rather than in the site you're working on.

I really think this could be important for drush_make and would really like the usefulness to be considered by the wider community.

Whoops: patch and makefile attached now.

This sounds like a good idea, but I think it would be better suited for another project.

@jp.stacey Good points -- it turns out that there is already good existing infrastructure for enabling modules and setup upon install of a Drupal site. See the Profiler in Drupal 6 for easy creation of install profiles. In Drupal 7 creating an install profile is already very easy. I don't think it makes sense for drush make to duplicate functionality that is meant to be addressed by an entire API in core.

In addition, note that the approach taken by your patch makes an important assumption -- namely that the Drupal site has already had its database setup and installed (you cannot run drush enable on a non-installed Drupal site). How is this possible if it is your first time building a site, especially given that it is not possible to install D6 from the command line?

If anything, this should be a task to adjust the drush make project page text to clarify the meaning of "site" -- which in this context means "codebase".

In my humble opinion you've got it backwards: drush make doesn't do enough. Not even close.

• It doesn't copy default.settings.php to settings.php and set the permissions so the installation can go ahead
• It doesn't create the "files" subdirectory, or set the permissions of the "default" folder so the website installer is allowed to create it for you
• You don't have an option to pass the database setup parameters so you don't go have through the web interface to actually set up the site
• It doesn't enable any of the installed modules (for which you need a working site)
• It doesn't add any languages (for which you need to have the locale module enabled)
• It doesn't download any translation files (for which you need those languages)

In short: it is a far cry from a "working site", I estimate that I still have to do more than two thirds of the installation manually.

If I have to manually enable every module with drush en, I might just skip "make" and install them with drush dl too.

Oh, wait: I can just write a shell script with a bunch of drush commands. It wouldn't actually even be harder than trying to make this thing skip through the hoops. Yeah, just strike this whole project.

Oh, and "make" is a misnomer. Every time you run make it redownloads and reinstalls everything, instead of just what has been added.