patch add and fix cvd ids.

CommentFileSizeAuthor
#13 examples-d6-cvs-id_1.patch4.79 KBilo
#10 examples-d6-cvs-id_1.patch5.42 KBilo
#8 examples-d6-cvs-id.patch15.5 KBrstamm
#5 examples-d7-cvs-id-3.patch20.6 KBrstamm
#2 examples-d7-cvs-id-2.patch23.9 KBrstamm
examples-d7-cvs-id.patch21.3 KBrstamm

Comments

Status: Needs review » Needs work

The last submitted patch, examples-d7-cvs-id.patch, failed testing.

rstamm’s picture

rstamm commented
StatusFileSize
new examples-d7-cvs-id-2.patch23.9 KB

patch failed because of the windows line endings of vertical_tabs_example.info and vertical_tabs_example.js files.

new patch add and fix cvs ids and convert line endings.

rstamm’s picture

rstamm commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, examples-d7-cvs-id-2.patch, failed testing.

rstamm’s picture

rstamm commented
Status: Needs work » Needs review
StatusFileSize
new examples-d7-cvs-id-3.patch20.6 KB
rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

Thanks so much.

Committed to HEAD: http://drupal.org/cvs?commit=405818

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Version: » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)

I assume there's a 6.x version coming now :-)

rstamm’s picture

rstamm commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new examples-d6-cvs-id.patch15.5 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

Standard set by core in .info files is to not need a line between the CVS ID and the rest of the file.

ilo’s picture

ilo commented
Status: Needs work » Needs review
StatusFileSize
new examples-d6-cvs-id_1.patch5.42 KB

Removed all the .info stuff.

Status: Needs review » Needs work

The last submitted patch, examples-d6-cvs-id_1.patch, failed testing.

ilo’s picture

ilo commented

Probably failed because scaffolding and element modules are not in project. I'll review all files again.

ilo’s picture

ilo commented
Status: Needs work » Needs review
StatusFileSize
new examples-d6-cvs-id_1.patch4.79 KB

here we go..

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Reviewed & tested by the community

Cool to commit, IMO.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed to DRUPAL-6-1, http://drupal.org/cvs?commit=427668.

Thanks ilo, @Ralf!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.