Closed (won't fix)
Project:
Examples for Developers
Version:
6.x-1.x-dev
Component:
Form Example
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Jul 2010 at 13:47 UTC
Updated:
30 Dec 2015 at 21:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
rfayI agree -
The D7 version may be more fleshed out, but I'd like to make these both completely generic as a nice extensible framework for multistep.
Comment #2
rfayStarting with a Drupal 7 wizard example that is extensible.
Comment #3
coltraneRandy and I discussed this at DrupalCamp Colorado and I'm all for a framework for multi-step forms.
I've looked through the patch but I'll apply it and provide a more thorough comment. (consider this a subscribe and a +1 :)
Comment #4
coltraneRandy and I talked about this today on irc. I was against a sequential method with integers at first, but it really is a great way to start working with multistep. So +1! Some minor things:
The file is form_example_wizard.inc, right?
minor, but it's "extensible"
Comment #5
ilo commentedThanks coltrane, I've fixed that, and also this other minor:
cousin's aunt's Social number? lol.. too confusing to even guess the name, ('aunts_name' is the field).. Randy patches are always that fun!!
I'm trying to figure out how to write tests for this..
Comment #6
ilo commentedI've documented most of the functions and their usage, including tips like 'you are not required to change this function'..
I've splitted _submit to next_submit and left a final _submit hook to do all the processing, this way next and previous buttons have their own specific handlers that 'are not required to be changed'.
Wizard steps are defined out of the form builder, now it looks eassier to understand what the user needs to touch and what is 'not required to be changed'.
Including some tests, but they need a lot of love.
and also fixed the issue detected by coltrane
Comment #7
ilo commentedbumping again to top.
Comment #8
rfayWow, ilo - thanks for the great work on this. It was significantly improved by what you did.
This patch has:
Comment #9
ilo commentedcoltrane, feel free to mark as rtbc if you think the mutilform example now is what you have expected.
Thanks for the review and the changes, rfay!
Comment #10
ilo commented#8: form_example_wizard_867224_08.patch queued for re-testing.
Comment #11
ilo commentedso.. It is ready.
Comment #12
rfayCommitted to HEAD: http://drupal.org/cvs?commit=436176
Perhaps we should try this in D6 as well.
Comment #13
ilo commentedI don't know if D6 an D7 form examples are similar or this requires a major rewrite, but I'm in favour of having a D6 example with the same layout, options, forms and whatever as in D7 to easy its mainteinance.
Comment #14
mile23It's end-of-life time for the 6.x-1.x branch of Examples. See #2642596: D6, D7 Roadmap for Examples