When you click on 'configure permissions' at 'admin/by-module' (and probably other places), a hash is sent along with the url so the permissions page scrolls to that module. With the 'Collapse modules on permissions page' option, the hash in the URL doesn't have any meaning anymore + people might get confused or forget which permissions they wanted to look at or change. Patch attached looks at the hash in the URL and keeps the permissions open for the particular module.

CommentFileSizeAuthor
#3 admin_menu.perms-hash.3.patch1.15 KBsun
admin_menu_permission_hash.patch1.39 KBswentel

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work 
+++ admin_menu.js	31 Jul 2010 17:46:38 -0000
@@ -68,6 +68,9 @@ Drupal.behaviors.adminMenuCollapseModule
+      var $module_id = 'admin-menu-hash';
+      var $module_hash = $(location).attr('hash').replace('#', '');

1) Neither $module_id nor $module_hash seem to be jQuery objects, so neither of both should use $ in the variable name.

2) What is the module_id variable for? I do not understand the default value.

3) That looks like a quite complex method to access window.location.hash -- any reason for doing it that way?

+++ admin_menu.js	31 Jul 2010 17:46:38 -0000
@@ -78,9 +81,12 @@ Drupal.behaviors.adminMenuCollapsePermis
+              $module_id = $row.children('td').attr('id');

I guess we can limit to td:first here, no?

Powered by Dreditor.

ClearXS’s picture

ClearXS commented

Sorry, but trying to find what causes a strange sudden error in D6 with all my links going unworkable to:
mysite.org/#admin/etcetera...

...I only find this page and have no idea where to look or file the issue.

I have no idea why I have that # that causes pages not working anymore. I'm not even aware of ticking other modules on or of (although system errors can occur). Probably have updated a lot of modules yesterday (just very recent updates), but which one could have caused this..?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Fixed
StatusFileSize
new admin_menu.perms-hash.3.patch1.15 KB

Thanks for reporting, reviewing, and testing! Committed attached patch to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

#1563860: Modules/Permissions do not collapse when Overlay is enabled claims a bug and adjusts this change.