#684016: Fix E_NOTICE notifications commented out the line:

$this->assertText(t('Project @title has been created.', array('@title' => $prj['title'])));;

This needs to be reinstated, hopefully before the next stable release.

CommentFileSizeAuthor
#3 storm--870428-3.patch2.02 KBjuliangb
#1 storm--870428-1.patch830 bytesjuliangb

Comments

juliangb’s picture

juliangb commented
Status: Active » Needs review
StatusFileSize
new storm--870428-1.patch830 bytes

This patch just puts back the test. It doesn't attempt to fix yet.

CNR is only to retest that test fails.

Status: Needs review » Needs work

The last submitted patch, storm--870428-1.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm--870428-3.patch2.02 KB

Test also failed locally.

The reason it fails is that we get a validation error stating "An illegal choice has been detected. Please contact the site administrator.". This is because the default value has isset(...) ? ... : NULL - rather than 0.

The attached patch made all tests pass locally.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.