VersioncontrolRepository::exportAccounts() is totally broken - it just calls itself. And only sort of, it does it off an invalid variable. I don't know where the actual implementation code for this went, but it's totally broken right now.

CommentFileSizeAuthor
#2 0001-fix-VersioncontrolRepositoryImportExport-interface-m.patch3.65 KBmarvil07

Comments

marvil07’s picture

marvil07 commented
Assigned: Unassigned » marvil07

upps.. :-p

let me take a look

marvil07’s picture

marvil07 commented
Title: VersioncontrolRepository::exportAccounts() calls itself » VersioncontrolRepository::{import,export}Accounts() are not propertly implemented
Assigned: marvil07 » Unassigned
Status: Active » Needs review
StatusFileSize
new 0001-fix-VersioncontrolRepositoryImportExport-interface-m.patch3.65 KB

Ok, the problem is more general, for the VersioncontrolRepositoryImportExport interface.

I am following the same way is used for all other interfaces.

sdboyer’s picture

sdboyer commented

I'll look at this patch next week when I get back onto VCAPI (tmrw is working on the migration scripts, and I'm out thurs/fri), but looking at how those interfaces are used is on my hit list, anyway. I'm not sure I'm a fan :/ more details when I get to it.

marvil07’s picture

marvil07 commented
Issue tags: +git phase 2, +versioncontrol account refactor

tagging

marvil07’s picture

marvil07 commented
Status: Needs review » Closed (won't fix)

Changing status as my last patch propose: #983926-2: Remove account class