The new detailed watchdog output is great when viewing an individual watchdog entry - can see the full details of the form submission and the Result of Mollom's analysis.

But when viewing the recent log entries page (filtered by Mollom) in order to look for false positives you only ever see something like

Spam:
Array
(
    [post_title] => ...

whereas previously you could see some of the actual content posted and hence it was possible to catch any false positives.

Obviously, clicking on each Spam item to check the details is not entirely feasible!!!

Any thoughts on a way round this?

CommentFileSizeAuthor
#13 mollom-HEAD.log-teaser.13.patch13.7 KBsun
#11 mollom-HEAD.log-teaser.11.patch13.67 KBsun
#3 mollom-DRUPAL-6--1.log-teaser.3.patch13.32 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Problem viewing mollom messages in watchdog - can't catch false positives » Log message summaries do not show valuable information

Better title. Not entirely sure what to do here.

1) A "better" summary would likely imply to output some sort of a "teaser". However, that would duplicate the rest of the log message.

2) Not sure whether stripping that needless "Array(" + related white-space might be sufficient. May require to build our own variable export helper function.

gpk’s picture

gpk commented

Many thanks for the reply. On reflection I think a "teaser" might be the best bet. http://api.drupal.org/api/function/dblog_overview/6 truncates messages to 56 characters (say, half a line) so I think any duplication would be minimal. Mollom could massage the message and variables so that the truncated version includes as much info as possible, e.g. the full version might look like:

Spam: Cheap watches // Buy your Rolex Citizen Casio

Details:

[post_title] => Cheap watches
[post_body] => Buy your Rolex Citizen Casio www.cheapwatches.buy other spammy content
[author_name] => kabPayotsxxxx
[author_mail] => kabPayotsxxxx@gmail.routexxxxxx.com
[author_ip] => 91.216.122.xx

etc.,

so that in the log message summary you get to see

Spam: Cheap watches // Buy your Rolex Citizen Casio...

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
StatusFileSize
new mollom-DRUPAL-6--1.log-teaser.3.patch13.32 KB

Status: Needs review » Needs work

The last submitted patch, mollom-DRUPAL-6--1.log-teaser.3.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 6.x-1.13 » 6.x-1.x-dev

Seriously, I still have no idea what testing against CVS tags is good for. :(

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review

#3: mollom-DRUPAL-6--1.log-teaser.3.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, mollom-DRUPAL-6--1.log-teaser.3.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Reviewed & tested by the community

So it looks like testing mode is still broken:

Error 0 NULL from 'http://xmlrpc1.mollom.com' mollom.getServerList
Error -110 'Connection timed out' from 'http://xmlrpc1.mollom.com' mollom.getServerList

Hopefully, the new backend will be available soon (as we cannot test any patches until then).

Since this patch technically cannot break anything, I suggest we go ahead.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to DRUPAL--6-1. Needs to be ported to CVS HEAD.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new mollom-HEAD.log-teaser.11.patch13.67 KB

Let's see what fails.

dries’s picture

dries commented

Nothing fails?! Punches himself. :-)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new mollom-HEAD.log-teaser.13.patch13.7 KB 
+++ mollom.module	12 Sep 2010 04:35:29 -0000
@@ -1286,21 +1290,34 @@ function mollom_validate_analysis(&$form
-        watchdog('mollom', 'Ham: <pre>@message</pre>Result: <pre>@result</pre>', array('@message' => print_r($data, TRUE), '@result' => print_r($result, TRUE)));
+      _mollom_watchdog(array(
...
-        watchdog('mollom', 'Spam: <pre>@message</pre>Result: <pre>@result</pre>', array('@message' => print_r($data, TRUE), '@result' => print_r($result, TRUE)));
+      _mollom_watchdog(array(
...
-        watchdog('mollom', 'Unsure: <pre>@message</pre>Result: <pre>@result</pre>', array('@message' => print_r($data, TRUE), '@result' => print_r($result, TRUE)));
+      _mollom_watchdog(array(

Wrong indentation.

Powered by Dreditor.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD! Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit a353dc0 on master, fai6, 8.x-2.x, fbajs, actions by Dries: 
    - Patch #880082 by sun: log message summaries do not show valuable...

  • Commit a353dc0 on master, fai6, 8.x-2.x, fbajs, actions by Dries: 
    - Patch #880082 by sun: log message summaries do not show valuable...