This was a UI WTF for me :(
Just upgraded a dev site from last weeks D7-HEAD. My Images all got big all of a sudden (ignoring their image size presets). OK, just a normal upgrade thing. Lets re-check their settings...
After looking at the settings a few times, scanning the code, checking for missing modules, looking for issues in the d.o queue, doing a few diffs to find out what changed, and making a brand-new test site just to see if I could replicate it, I eventually found where the option had gone away to. non-obvious
Now, the change that was made was obviously a sensible and needed one. That list was getting silly with all the options that are possible. So YAY.
BUT can we please make the button that you press to edit something say "Edit"? "Submit" is what you press after you've made a change you are happy with, not when you are first looking for options.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | field_ui-882914-20100814.patch | 815 bytes | dman |
| #1 | field_ui-submit_button-before2.png | 49.88 KB | dman |
| field_UI-submit_button.png | 51.73 KB | dman | |
| field_ui-submit_button-before.png | 78.53 KB | dman |
Comments
Comment #1
dman commentedBetter screenshots,
Comment #2
dman commentedLooks like the button never got ANY text set, and I'm seeing a browser default. Though the alt text implies it is EXPECTED to be 'Edit'.
Not sure if that's intentional, but this patch makes me happier. THOUGH It may be that the purpose button is ambiguous...
I can't tell yet.
Comment #3
dman commentedAll it is is:
But go for it testbot.
Comment #4
yched commentedThat's because of #883336: theme_image_button() broken (needs tests only). That should be a cogwheel image in that button, not default text added by the browser.
Comment #5
dman commentedThanks. I guess that makes sense.
If it fails like this just because of a theme image, it doesn't feel very accessible though...
So we'll see how the other issue turns out.