As reported at #796658-184: UI for field formatter settings

Image button from formAPI always returned as submit type but type="image" should be default.

CommentFileSizeAuthor
#6 patch_output_button.patch5.11 KBartusamak
#1 drupal.form-image-button.1.patch689 bytessun
theme_image_button-d7.patch745 bytesandypost

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: +Needs tests
StatusFileSize
new drupal.form-image-button.1.patch689 bytes

The fact that we were able to break it means that we don't have any test for image buttons.

yched’s picture

yched commented
Status: Needs review » Reviewed & tested by the community

This is seriously bugging end users, because until this is fixed, image_buttons, without an actual image, are rendered (at least in FF) with a default 'Submit' text (in the browser's locale, french, russian, which looks really scary in the middle of an english page...)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: theme_image_button() broken » theme_image_button() broken (needs tests only)
Status: Fixed » Needs work

We still need tests here.

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented
Assigned: Unassigned » artusamak

I'm writing a test right now, i'll post it when it'll be ready.

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented
Assigned: artusamak » Unassigned
StatusFileSize
new patch_output_button.patch5.11 KB

Here is a first version of the test, i've got one problem with it if somebody can help about that, i'm testing a raw assertion and the result is always false whereas the output of the verbose message and the output of the debug check plain content are equals for the tests testImageButtonMulticlassOutput and testImageButtonDisabledOutput.
If someone has an explanation about what i'm doing wrong, i'll be thankful.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

Let's test the patch. There's no new line at the end of the file

Status: Needs review » Needs work

The last submitted patch, patch_output_button.patch, failed testing.

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented

I'm not sure to understand what i have to do with your comment "There's no new line at the end of the file".
The test failed, it's normal because i have my assertion issue.

andypost’s picture

andypost
he/him
Primary language Russian
commented

I mean that at the bottom of the patch 

+}
\ Pas de fin de ligne à la fin du fichier.
sun.core’s picture

sun.core commented
Priority: Major » Normal

Only touches tests, so demoting to normal.

Tor Arne Thune’s picture

Tor Arne Thune commented
Version: 7.x-dev » 8.x-dev
Category: bug » task
Issue tags: +Needs backport to D7

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

  • Dries committed 155d2c1 on 8.3.x 
    - Patch #883336 by sun, andypost: theme_image_button() broken.

  • Dries committed 155d2c1 on 8.3.x 
    - Patch #883336 by sun, andypost: theme_image_button() broken.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

  • Dries committed 155d2c1 on 8.4.x 
    - Patch #883336 by sun, andypost: theme_image_button() broken.

  • Dries committed 155d2c1 on 8.4.x 
    - Patch #883336 by sun, andypost: theme_image_button() broken.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

  • Dries committed 155d2c1 on 9.1.x 
    - Patch #883336 by sun, andypost: theme_image_button() broken.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.