if (!@copy($source, $destination)) {
    drupal_set_message(t('The specified file %file could not be copied.', array('%file' => $source)), 'error');
    return FALSE;
  }

Spits errors to the screen even when errors are set not to display, doesn't tell you the destination.

CommentFileSizeAuthor
#5 883400-file-watchdog.patch614 byteschx
#1 file.patch599 bytescatch
file.patch602 bytescatch

Comments

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new file.patch599 bytes

watchdog arguments and dsm() arguments sadly not the same.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

That's a good idea.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

chx’s picture

chx commented
Status: Closed (fixed) » Reviewed & tested by the community
StatusFileSize
new 883400-file-watchdog.patch614 bytes

#874326: Invalid scheme fails to halt processing of a stream request partially reverted this.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

#5: 883400-file-watchdog.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-dev » 8.x-dev

Although badly needed, this is D8 material according to the rules (I had to learn today). It may be backported at a later point in time (though that's unlikely).

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.x-dev » 7.x-dev

Just because a bug might not get fixed until D8, doesn't mean it should be moved to D8 in advance.

hgurol’s picture

hgurol commented

yes, lets move it to D9 then...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.