Theres a couple of extra divs in there we just don't need - all they do is add margin which can easily be applied to other divs already in the markup - core templates need to be lean and mean.

Patch removes:
- section div on messages
- section div on sidebars

Relates to #827526: Simplify footer region divs's in featured, footer and triptych - combined with this patch would be a considerable cleanup of page.tpl.php.

CommentFileSizeAuthor
bartik-remove-section-divs.patch2.53 KBJeff Burnz

Comments

jacine’s picture

jacine
she/her
Location New York
commented
Status: Active » Needs review

Yes, please. Subscribe :)

bleen’s picture

bleen commented 
+++ themes/bartik/templates/page.tpl.php	14 Aug 2010 23:08:02 -0000
@@ -143,9 +143,9 @@
+    </div> <!-- /#messages -->

nit-picky, but now that we are getting rid of the .section divs, can we lose those comments about what div is closing. I find those a bit silly.

Powered by Dreditor.

Jeff Burnz’s picture

Jeff Burnz commented

I think removing comments is another issue, if we remove one we logically would be removing them all? Not sure thats in the scope of this issue since its about documentation.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Version: 7.x-dev » 8.x-dev
Status: Needs review » Needs work

It's too late to revisit this right now, and while I'd like to have more semantic markup, it'll have to wait.
Also, patch doesn't apply.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Needs work » Closed (works as designed)

Bah, lets kill this, I think we're gonna end up rewriting big chunks of HTML if we go with a responsive makeover in any case.