Again, missing labels for form checkboxes.

CommentFileSizeAuthor
#3 simpletest_label_v2.patch714 bytesmgifford
simpletest_label_v1.patch704 bytesmgifford

Comments

mgifford’s picture

mgifford
he/him
Primary language English
commented

Same process used here - http://drupal.org/node/884932#comment-3338098

However I just noticed that the comment should be removed.

This is a super easy patch to apply.

Everett Zufelt’s picture

Everett Zufelt commented
Status: Needs review » Needs work

Looks good.

Definitely don't need the comment. Using documented (hopefully :) ) FAPI to hide label shouldn't need a comment.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new simpletest_label_v2.patch714 bytes

Thanks!

Status: Needs review » Needs work

The last submitted patch, simpletest_label_v2.patch, failed testing.

Everett Zufelt’s picture

Everett Zufelt commented

I fail to understand how that many failures and exceptions can be generated by the addition of a single line of markup.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs work » Needs review

#3: simpletest_label_v2.patch queued for re-testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented

Ok, so it seems to have been a bot error.

Now can we get this marked RTBC?

Everett Zufelt’s picture

Everett Zufelt commented
Status: Needs review » Reviewed & tested by the community

The type of hack fixes I envisioned being implemented over a year ago when we started working on the ability to have invisible form element titles.

RTBC

mgifford’s picture

mgifford
he/him
Primary language English
commented

We'll have to get this figured out when the new FAPI rolls out for D8..

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

#3: simpletest_label_v2.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Please merge this patch into #882694: Add missing form element titles for accessibility. Thanks.