Relative font size on tables causes too small fonts on nested tables - you can see this on the Available Updates page, or just nest some tables in a node and you'll see the issue.

CommentFileSizeAuthor
#10 bartik-table-fonts-2.patch464 bytesJeff Burnz
#5 bartik-tables-font-size.png8.5 KBJeff Burnz
#5 bartik-table-fonts.patch473 bytesJeff Burnz
#2 seven-nested-tables.patch478 bytesaspilicious
#2 text-format-layout-fixed.png36.63 KBaspilicious
bartik-nested-table-font-size-inheritance.png56.71 KBJeff Burnz

Comments

aspilicious’s picture

aspilicious commented

can we do something like this?

table table {
font-size: 1.0em;
}
aspilicious’s picture

aspilicious commented
Status: Needs review » Active
StatusFileSize
new text-format-layout-fixed.png36.63 KB
new seven-nested-tables.patch478 bytes

Oh yes we can.
Bit ugly but it is a fix.
Someone else a better idea?

Screenshot:
-----------
Left: after patch
Right: before patch

aspilicious’s picture

aspilicious commented
Status: Active » Needs review
aspilicious’s picture

aspilicious commented
Status: Active » Needs review

Whoops this is a seven patch XD.
Ok Bartik has the same problems...
Same fix?

TESTED:
Off course same fix, maybe we should add something in core stopping nested items to be smaller and smaller.

Jeff Burnz’s picture

Jeff Burnz commented
StatusFileSize
new bartik-table-fonts.patch473 bytes
new bartik-tables-font-size.png8.5 KB

lol, I got one also, but for Bartik.

bartik-tables-font-size.png

bleen’s picture

bleen commented
Status: Needs review » Reviewed & tested by the community

ugly == true
correct fix for this issue == true
RTBC == true

aspilicious’s picture

aspilicious commented

#2 AND #5 need to be commited.

aspilicious’s picture

aspilicious commented
Status: Reviewed & tested by the community » Needs work

Can someone combine these patches. (me not have much time)
Found another table issue.

Go to add story page ==> go to the additional info page for filters
table is to small.

ul.tips table {
  font-size: 1.0em;
}

has to be added

Jeff Burnz’s picture

Jeff Burnz commented
Assigned: Unassigned » Jeff Burnz

OK, I'll combine them up today and post one big one.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Needs work » Needs review
StatusFileSize
new bartik-table-fonts-2.patch464 bytes

OK, so this is starting to feel like whack-a-mole CSS and one thinks that font sizing needs a serious review in Bartik (its a bit mad imo).

Patch accounts for .tips table now also. The seven patch can be combined with another patch I wrote as a cleanup for some other font size regressions in Seven.

Jeff Burnz’s picture

Jeff Burnz commented

The seven patch was combined with this one #883028: Seven font size cleanups, could use a review also, cheers.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
Jeff Burnz’s picture

Jeff Burnz commented
Status: Reviewed & tested by the community » Active

I want to close this in favour of #660614: Remove #block-system-main dependency, fix font sizes, remove crufty CSS, where I slightly changed how font sizing works so we can test it over there, or leave this open?

Keep this active for now, but please don't commit this just yet...

Jeff Burnz’s picture

Jeff Burnz commented
Status: Active » Postponed

Actually lets postpone this, I think we can nail it in the other patch or do it later.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Postponed » Fixed

Got fixed in #660614

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.