This bug could be filed in a number of places: UX, File system, Field system. I was testing a different issue and was very confused because I changed to 'private' files at admin/config/media/file-system but when uploading files on the default 'Article' node type, the files still upload to the public folder.
This is because we have per-field public/private file handling, which is good, but it's very confusing from a UI standpoint, because I didn't even know this was possible. I thought core was broken.
A couple of possible fixes:
1) When changing file method, change all field instances automatically.
Probably a bad idea, since mixed-use would be destroyed by this approach.
2) When changing file method, display a message to the user.
Probably the best option, the question is what information to display. We may be able to provide links to each field affected by the change.
3) Move/consolidate the public/private file settings to a single location.
Probably not feasible.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 890716-file-settings.patch | 1.67 KB | agentrickard |
Comments
Comment #1
agentrickardTurns out that changing the "default" file behavior also doesn't change the default settings of newly created fields.
Perhaps we just remove this global setting?
Comment #2
agentrickardFirst, simple patch to fix implementations in File and Image modules, so that defaults are respected when creating new fields.
Comment #3
agentrickardSplitting off the secondary UI issue. We need a way to give an admin link to edit a field instance. It is not clear from the current API that this is possible. See #890804: Separate function to determine admin links for field instances
Comment #4
Letharion commentedLooks good to me. Assuming the tests check out, it should be committed.
Comment #5
webchickMakes sense. Is also security-related, so it's good to get this cleaned up before beta.
Committed to HEAD!