This makes it really fiddly moving or copying code between themes, and sets a bad example for contrib.

Any chance we can run a perl -pie on Garland's template.php to fix this?

Comments

reglogge’s picture

Status: Active » Needs review
StatusFileSize
new5.31 KB

you mean like this?

Jeff Burnz’s picture

Maybe this is a good change, if only to be consistent with the other core themes. Not really seeing the bug here though, isn't it more of a task?

joachim’s picture

Category: bug » task

Fair enough :)

thedavidmeister’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

All $vars were converted to $variables in d8 #1963942: Change all instances of $vars to $variables, so this is a d7 only issue.

Patch no longer applies.

Patch does not fix garland_preprocess_node() or garland_preprocess_comment().

Review bonus #2094585: [policy, no patch] Core review bonus for #1987410: [meta] system.module - Convert theme_ functions to Twig.

sandipmkhairnar’s picture

Status: Needs work » Needs review
StatusFileSize
new6.04 KB
lauriii’s picture

Issue tags: -Needs reroll

Patch applies and works

nico.knaepen’s picture

Component: Garland theme » ajax system
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Licensing
Yes: Follows the licensing requirements.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.

David_Rothstein’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed a70cff3 on 7.x
    Issue #890934 by sandipmkhairnar, reglogge: Garland uses $vars instead...
reglogge’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.