Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
ajax system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Aug 2010 at 13:49 UTC
Updated:
29 Oct 2015 at 17:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
reglogge commentedyou mean like this?
Comment #2
Jeff Burnz commentedMaybe this is a good change, if only to be consistent with the other core themes. Not really seeing the bug here though, isn't it more of a task?
Comment #3
joachim commentedFair enough :)
Comment #4
thedavidmeister commentedAll $vars were converted to $variables in d8 #1963942: Change all instances of $vars to $variables, so this is a d7 only issue.
Patch no longer applies.
Patch does not fix garland_preprocess_node() or garland_preprocess_comment().
Review bonus #2094585: [policy, no patch] Core review bonus for #1987410: [meta] system.module - Convert theme_ functions to Twig.
Comment #5
sandipmkhairnar commentedComment #6
lauriiiPatch applies and works
Comment #7
nico.knaepen commentedManual Review
Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Licensing
Yes: Follows the licensing requirements.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Comment #8
David_Rothstein commentedCommitted to 7.x - thanks!
Comment #10
reglogge commented