Fix tests

for the record

Repository class unit tests works after http://drupal.org/cvs?commit=410920

the tests needed to fix are:

- Version Control Account Status functional testing
- Version Control Repository Management functional testing

debugging and fix the 2nd param passed to VersioncontrolEntityController::load() at testAddRepository()

Notice that there is a problem at the defaultPrefix on the query object generated, it is empty instead of being the one selected by simpletest.

A dbtng problem?

tagging, we really need this sooner than later. like, now.

Link back to dbtng issue: #914392: While testing, default prefix is used instead of simpletest prefix by dbtng-driven queries

oopps

#957262: Make sure autoload registry is setup peripherally associated with getting tests working.

Let me make a little summary of what is happening with tests:

• We have the main CRUD for repositories working on the usual user workflow outside simpletest.
• We have problems running the basic CRUD verifications. It seems like the problems are in compatibility between dbtng and simpletest, so even applying these patches I am still having problems running the basic tests.
  • At simpletest: neclimdul have provided a patch at #890440-14: Backport latest SimpleTest code from D7, that it's actually a patch for the simpletest patch to core(so it is needed to re-apply it to core).
  • At dbtng:
    • The main problem seems to be that prefixes are not handled correctly on simpletest environment, so the patch at #914392-5: While testing, default prefix is used instead of simpletest prefix by dbtng-driven queries should fix that. Sadly, I could not reproduce it, so I started a really basic test(based on d7 DB core tets) on the same issue #914392-11: While testing, default prefix is used instead of simpletest prefix by dbtng-driven queries to prove the basic CRUD with dbtng on simpletest is broken
    • ... but that last patch with the _trivial test_ breaks badly because it seems like autoload is not getting the right information at the right time, so applying the patch at #957262: Make sure autoload registry is setup fix the autoload problem, but dbtng basic CRUD test are still not working for me.

It seems like we are blocked until patches on dbtng and simpletest get in.

That's a pretty good summary but there's one more problem. Just to make it a little more concise as I think I may be the only one able to get vcapi tests running atm.

1) Prefixes don't work in simpletests. patch: #914392-5: While testing, default prefix is used instead of simpletest prefix by dbtng-driven queries
2) autoload doesn't register dbtng object during simpletests. patch: http://drupal.org/node/957262#comment-3654338
3) dbtng_init() doesn't get called in simpletests so we don't have the global $databases variable initialized. psuedo-patch: #955996-6: Exception: The specified database connection is not defined: default)
4) Random failures when logining in users or making requests because of invalid headers. patch: #890440-14: Backport latest SimpleTest code from D7

I am now depending on DBTNGTestCase (see #914392: While testing, default prefix is used instead of simpletest prefix by dbtng-driven queries for details).

Still work to do, but finally I think I can work on versioncontrol stuff(not its dependencies)

Use what is on DBTNGTestCase instead of depending on it since we already have a base class for testing :-)

blame on me for forgetting remove the dependency

updated to add recently views dependency.

all test except account status working (but waiting other projects commits too)

Oh man. Screen fulla green. Way to go, folks.

mmm, this is not really completely committed.. in the other side I need to update the patch since there was some changes in dbtng: #914392-23: While testing, default prefix is used instead of simpletest prefix by dbtng-driven queries

I will commit this patch, and after it, all tests are passing(except account status, but it is not really related to this :-p)

committed to HEAD: http://drupal.org/cvs?commit=448688

Just another related: #890216-17: change nomeclature to use $username(s) instead of $vcs_username(s)

It makes account status module test to pass, so finally all test would be working again.