To hide the "Write message link" shows the current user their own data in a views display extend the functionality of the views handler field views_handler_field_privatemsg_link.

The result from the attached patch:
Shows an user their own data in a views display the link to write a message are not displayed. This is usefull for example in relationships lists.

CommentFileSizeAuthor
#2 views_handler_field_privatemsg_link.patch996 bytesquiptime
views_handler_field_privatemsg_link.patch996 bytesquiptime

Comments

Status: Needs review » Needs work

The last submitted patch, views_handler_field_privatemsg_link.patch, failed testing.

quiptime’s picture

quiptime commented
StatusFileSize
new views_handler_field_privatemsg_link.patch996 bytes

Patch reattached.

Edit:
The system f.. not accept my new attachment.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Closed (duplicate)

No new features/changes are added to the 6.x-1.x branch and 6.x-2.x already contains a feature which allows to show/hide the link for the current user globally, not only for the views field.

See http://blog.worldempire.ch/de/api/function/privatemsg_get_link/6-2

quiptime’s picture

quiptime commented
Status: Closed (duplicate) » Active

You say
No new features will be added to branch 1 ...

You say
New features will be added only to the branch 2 ...

1. What is the state of the branch 2?
2. Is this branch ready for production?

3. Wath is with the extremly not practicable usability (block/unblock link, write message link) of the branch 1?
4. What is with the wrong confirm messages (block/unblock action: ... this can not be undone ...) of the branch 1?
5. What is with the missing realname compatibility of the branch 1?

What will you say to all users that use the branch 1 in the context of the questions 3., 4. and 5.?

If the branch 1 outdated please make branch 2 stable and ready for production and close branch 1.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Closed (duplicate)

Only bugs are fixed in 6.x-1.x, no new features, no changes, no string changes. That is the point of stable releases. And 6.x-1.x isn't perfect obviously, but at some point, we just had to make it stable or we would still be working on it.

I am working on making 6.x-2.x the stable version, obviously. But that takes time. See #721974: Roadmap for 6.x-2.x. 6.x-2.x is production ready as in it is safe, works and is in many ways much improved compared to 6.x-1.x. *But* there will be (more) UI changes, API changes and feature changes. We have many tests to ensure that it is working and I'm continually working on improving them.

3. That there is no missing API function has nothing to do with UX and what you said about the write message link is simply not true.
4. No string changes in the stable branch. Not nice, but not really a problem. Already fixed in 6.x-2.x (there is also a separate page to manage blocked users in that branch)
5. That is a bug and can be fixed without changing the translation string or something else, so it can be fixed in 6.x-1.x (and ported to the other patches).

And because these questions have nothing to do with this patch, there is no point to re-active it again.