Use new backend for running tests

+++ mollom.inc	26 Aug 2010 19:22:11 -0000
@@ -66,8 +66,15 @@ function _mollom_authentication($public_
+  if (!empty($GLOBALS['drupal_test_info']['in_child_site'])) {
+    $servers = array('http://xmlrpc1.mollom.com');
+  }
+  else {
+    $servers = array('http://xmlrpc1.mollom.com', 'http://xmlrpc2.mollom.com', 'http://xmlrpc3.mollom.com');
+  }

Though what I don't understand is why communication fails with xmlrpc1 already?

I.e., it's not the subsequent XML-RPC requests that are failing, but the initial mollom.getServerList request that times out...

Powered by Dreditor.

mollom-HEAD.force-backend.0.patch queued for re-testing.

Error 500: http://xmlrpc1.mollom.com - Internal Server Error - mollom.getServerList

is not visible in the test results, possibly caused by the client sending empty/no API keys. Johan will resolve that.

I'm a bit confused why we don't see that watchdog error in the test results though. Originally, I figured that we forgot to make mollom.getServerList always return xmlrpc1 only (which was the case), so the server fallback code in mollom() just simply skipped to the next server without logging an error.

However, looking at the actual error message and its format, then this log message does not originate from mollom(), but from _mollom_retrieve_server_list() itself:

function _mollom_retrieve_server_list() {
  $servers = array('http://xmlrpc1.mollom.com');
  foreach ($servers as $server) {
    $result = xmlrpc($server . '/' . MOLLOM_API_VERSION, array('mollom.getServerList' => array(_mollom_authentication())));
    if (!xmlrpc_error()) {
      return $result;
    }
    else {
      watchdog('mollom', 'Error @errno: %server - %message - mollom.getServerList', array('@errno' => xmlrpc_errno(), '%server' => $server, '%message' => xmlrpc_error_msg()), WATCHDOG_ERROR);
    }
  }
  return xmlrpc_errno();
}

mollom() errors are using:

            'text' => 'Error @errno from %server for %method: %message: <pre>@data</pre>',

This means that _mollom_retrieve_server_list() logged the watchdog error, but our assertMollomWatchdogMessages() did NOT catch it. :(

I'm not able to manually reproduce that we're NOT catching that error in test results.

Enforcing xmlrpc1 also for the mollom.getServerList result now.

Not sure how, but there've been still some log messages containing:

Refreshed servers: http://174.37.205.152, http://67.228.84.11, http://88.151.243.81

So now totally enforcing a hard-coded server list.

ok, without the port :)

Enforced through the backend itself now.