What is the point of this CSS?
#branding div.block {
position: relative;
float: right;
width: 240px;
padding-left: 10px;
background: #333;
}
#branding div.block form label {
display: none;
}
#branding div.block form div.form-item {
float: left;
border: 0;
margin: 0;
padding: 0;
}
#branding div.block form input.form-text {
width: 140px;
margin-right: 10px;
}
#branding div.block form input.form-submit {
text-align: center;
width: 80px;
}
There is no region in the #branding div, and this code is inaccessible. It's styled with a #333 background and #000 as color. I'm assuming this is old code that possibly targeted a login block at one point?
I've attached a patch to remove it, unless someone can explain.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | seven-branding_2.patch | 864 bytes | Jeff Burnz |
| seven-branding.patch | 736 bytes | jacine |
Comments
Comment #1
jessebeach commentedReviewed and agreed that the #branding element has no regions in it, so no way to assign a block to it. This code is superfluous and is safe to remove.
Comment #2
Jeff Burnz commentedseven-branding.patch queued for re-testing.
Comment #3
Jeff Burnz commentedstrait re-roll chasing HEAD, was reviewed in #1, agree this is useless doing nothing code.
Comment #4
sunAlthough a nice clean-up, this is D8 material according to the rules (I had to learn today). It may be backported at a later point in time.
Trust me, I'd love to fix this. But Drupal core maintainers only take actually required bug fixes into account for D7. Everything else is D8 material for now. I'm with you. I had to learn the hard way.
Comment #6
albert volkman commentedThis was resolved as of #1137782: Remove unused CSS in Seven theme that uses desktop-sized layouts. I'm going to mark the other for backport.