Allow setting Userpoints requirements by category [#896328]

This module doesn't currently allow setting the category from which Userpoints should be deducted, yet it is possible to categorize them, and we do this on the site I'm working on.

I'm going to modify it to allow that, and I will then submit a patch.

It seems this module hasn't changed between its 1.0beta release and its 1.x-dev release, but the patch will be against dev since it's really supposed to be...

Comment	File	Size	Author
#1	userpoints_contrib_nodelimit_896238_add_category_1.patch	2.62 KB	wizonesolutions
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

wizonesolutions

he/him

English

Norway

CreditAttribution: wizonesolutions commented 28 August 2010 at 21:52

File	Size
userpoints_contrib_nodelimit_896238_add_category_1.patch	2.62 KB

Here is the patch. I changed the function that checks for the variable, the one that updates it if the node type changes, and of course added an option to set it on the node forms. Also added a space to the end of the file.

Hope it gets reviewed!

Kevin

Comment #2

wizonesolutions

he/him

English

Norway

CreditAttribution: wizonesolutions commented 28 August 2010 at 21:52

Status:

Active

» Needs review

...and for that to happen, I should set it to needs review...which I am now doing.

Comment #3

Berdir

German

Switzerland

CreditAttribution: Berdir commented 12 February 2011 at 09:47

Status:

Needs review

» Needs work

+++ userpoints_nodelimit/userpoints_nodelimit.module
@@ -109,6 +109,14 @@ function userpoints_nodelimit_node_settings_form(&$form) {
+    '#default_value' => variable_get('userpoints_nodelimit_category_'. $form['#node_type']->type, '0'),

I think the default value should user userpoints_get_default_tid().

+++ userpoints_nodelimit/userpoints_nodelimit.module
@@ -144,7 +154,9 @@ function userpoints_nodelimit_node_type($op, $info) {
+  $selected_tid = variable_get('userpoints_nodelimit_category_' . $nodetype, NULL); //Retrieve the category against which they are checking points
+  if ($selected_tid == 0) $selected_tid = NULL; //If uncategorized, then revert to standard behavior

Can you move these comments above the code? Also add a period at the end.

Powered by Dreditor.