dashboard .module @ line 416:

-return '<div id="dashboard">' . $element['#children'] . '</div>';
+return '<div id="dashboard" class="clearfix">' . $element['#children'] . '</div>';
CommentFileSizeAuthor
#1 dashboard-wrapper-896494.patch697 bytesJeff Burnz

Comments

Jeff Burnz’s picture

Jeff Burnz commented
Status: Active » Needs review
StatusFileSize
new dashboard-wrapper-896494.patch697 bytes

Simple fix, works as expected.

mustanggb’s picture

mustanggb commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs review

Can we get a screenshot or so? This issue is a bit too cryptic for reviewers to understand.

Jeff Burnz’s picture

Jeff Burnz commented

Probably easier to show in a video: http://www.screencast.com/t/NmIzN2I4

Its to make theming the DIV wrapper around the dashboard elements easier - for example in the video I add a background color to the dashboard, without the clearfix not all the elements get wrapped. Ideally we should have the clearfix applied here, its not a deal breaker, but nice to have and doesn't mess with anything else.

bleen’s picture

bleen commented
Status: Needs review » Reviewed & tested by the community

Still RTBC

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

#1: dashboard-wrapper-896494.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Adding the .clearfix class surely doesn't hurt.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.