After #851168: db_find_tables() expects tables to be prefixed, inconsistent implementation and documentation, DatabaseSchema_sqlite::findTables() needs to be modified to support schemas (ie. the schema.table form for a table expression).

This is a requirement for #850852: Fix transaction failure and allow concurrent testing on SQLite.

Files: 
CommentFileSizeAuthor
#4 897650-limit-findtables-query-typo.patch1.02 KBGarrett Albright
PASSED: [[SimpleTest]]: [MySQL] 31,898 pass(es).
[ View ]
#3 897650-limit-findtables-query.patch1.02 KBGarrett Albright
PASSED: [[SimpleTest]]: [MySQL] 31,849 pass(es).
[ View ]
#1 897650-sqlite-find-table-schema.patch874 bytesDamien Tournoud
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 897650-sqlite-find-table-schema.patch.
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new874 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 897650-sqlite-find-table-schema.patch.
[ View ]

Status:Needs review» Needs work

The last submitted patch, 897650-sqlite-find-table-schema.patch, failed testing.

Title:DatabaseSchema_sqlite::findTables() doesn't support schemasDatabaseSchema_sqlite::findTables() shouldn't find indexes
Status:Needs work» Needs review
StatusFileSize
new1.02 KB
PASSED: [[SimpleTest]]: [MySQL] 31,849 pass(es).
[ View ]

It appears that the meat of this issue, that of supporting a schema prefix, has been fixed elsewhere. However, another part of the patch, that of limiting the query to only finding tables, still needs to be put into place, because otherwise, it may return indexes:

sqlite> SELECT name, type FROM sqlite_master limit 10;
variable|table
sqlite_autoindex_variable_1|index
actions|table
sqlite_autoindex_actions_1|index
batch|table
batch_token|index
blocked_ips|table
sqlite_sequence|table
blocked_ips_blocked_ip|index
cache|table

Reroll which addresses this, as well as clarifies a comment.

StatusFileSize
new1.02 KB
PASSED: [[SimpleTest]]: [MySQL] 31,898 pass(es).
[ View ]

D'oh. Another reroll to address confusion in my updated comment.

Version:7.x-dev» 8.x-dev
Status:Needs review» Reviewed & tested by the community
Issue tags:+needs backport to D7

Yep. Sorry about the breakage.

Please commit to D7 and D8.

Status:Reviewed & tested by the community» Fixed

Committed to 7.x and 8.x.

Status:Fixed» Closed (fixed)
Issue tags:-needs backport to D7

Automatically closed -- issue fixed for 2 weeks with no activity.