When logged into D7 as admin there are often two h2 elements with the text Management. One comes before the Management menu and one before the toolbar. This is a bit confusing. I think that it would better reflect the purpose of the list of links that form the toolbar if the text in its heading were changed to "Administrative Toolbar" or something similar.

I was going to roll a patch but I looked in toolbar.tpl.php for the heading and didn't find it. If someone can point out where the heading is generated I can roll a patch.

CommentFileSizeAuthor
#10 issue-898028-toolbar-heading-3.patch810 bytesEverett Zufelt
#6 issue-898028-toolbar-heading-2.patch796 bytesEverett Zufelt
#1 issue-898028-toolbar-heading.patch780 bytesEverett Zufelt

Comments

Everett Zufelt’s picture

Everett Zufelt commented
Status: Active » Needs review
StatusFileSize
new issue-898028-toolbar-heading.patch780 bytes

This patch changes the heading before the toolbar to "Administrative Toolbar". Not sure if this is the best place / method of making the change, but it works and affects nothing but the heading.

mgifford’s picture

mgifford
he/him
Primary language English
commented

It's actually $system_menus['management'] & not just 'management' however it seems that it's not spitting out anything more useful than that.

Why was this with a variable? Are there any other places this might be used? Is $system_menus['management'] used in any other contexts where hard coding this might be a problem?

Everett Zufelt’s picture

Everett Zufelt commented

@mgifford

I'm not sure if it is used in other contexts, but I agree that it is best to modify it in a more global setting. Do you know where this is originally set?

Bojhan’s picture

Bojhan commented

Management is used as menu in the left sidebar too. Toolbar is somewhat of a weird replication of it, ideally there would only be one label indeed.

dries’s picture

dries commented
Status: Needs review » Needs work 
+++ modules/toolbar/toolbar.module	1 Sep 2010 04:59:49 -0000
@@ -207,7 +207,7 @@
+    '#heading' => array('text' => t('Administrative Toolbar'), 'level' => 'h2', 'class' => 'element-invisible'),

We don't camel case every word in a title or sentence.

Everett Zufelt’s picture

Everett Zufelt commented
StatusFileSize
new issue-898028-toolbar-heading-2.patch796 bytes

Corrected heading from:

Administrative Toolbar

to

Administrative toolbar

Everett Zufelt’s picture

Everett Zufelt commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, issue-898028-toolbar-heading-2.patch, failed testing.

Everett Zufelt’s picture

Everett Zufelt commented

Will reroll this evening.

Everett Zufelt’s picture

Everett Zufelt commented
Status: Needs work » Needs review
StatusFileSize
new issue-898028-toolbar-heading-3.patch810 bytes
Bojhan’s picture

Bojhan commented
Status: Needs review » Reviewed & tested by the community

RTOTHEBC

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

David_Rothstein’s picture

David_Rothstein commented

Minor followup to remove the unused variable: #916488: Unused variable in toolbar_view()

Status: Fixed » Closed (fixed)
Issue tags: -Accessibility

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Accessibility

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.