Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
javascript
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Aug 2010 at 16:10 UTC
Updated:
29 May 2015 at 21:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
alex_b commentedPatch attached.
Now: http://skitch.com/alexbarth/dwq5p/installing-drupal-drupal
With patch: http://skitch.com/alexbarth/dwq5u/installing-drupal-drupal
Comment #2
devin carlson commentedI can confirm that Drupal.ajaxError() does use line breaks to format output and strips HTML output. The patch makes the error output readable.
Attached is the same patch but against D8.
Comment #4
jthorson commentedTestbot was misbehaving ... it's been punished accordingly. Resetting test.
Comment #5
jthorson commented#2: wrap-error-output-in-pre-tags-898582.patch queued for re-testing.
Comment #7
devin carlson commentedI'm going to assume that the testbot was misbehaving again...
Comment #8
jthorson commented#2: wrap-error-output-in-pre-tags-898582.patch queued for re-testing.
Comment #10
jthorson commentedOkay ... testbot beaten into submission. Tests passed.
Comment #11
devin carlson commentedAttached are two screenshots: one showing AJAX error output without the
<pre>tags and one with the<pre>tags added.Comment #12
nod_Error needs to be replanned, see #1606362: Use throw when an ajax error occurs and extend JavaScript's Error object.
That said it's a welcome improvement. Needs reroll though.
(edit) oh and don't put the
<pre>at this level, what we need it at the progress.js level, that's the only place we're adding the error output to the HTML.Comment #13
nod_Comment #14
applicity_sam commentedChecking to see how to replicate the issue as this seems to be resolved in issue #2000558
Comment #15
applicity_sam commentedIn order to test this we did the following:
- Created a new module with an update hook that dies.
- Run update.php to apply the database updates.
- Checked that the returned error message is wrapped in pre tags.
Confirmed as no longer an issue. Closing issues
Comment #16
nod_Thanks for checking!