In RTL the closing bracket for the theme name ends up at the beginning. I am not sure if this will happen if I have a full translation in arabic or hebrew but this still shouldn't really happen. This happens in at least Firefox and Opera.

Screen-shot is in start but occurs in Bartik also.

The attached patch solves this issue by not using brackets.

demonstrate-block-regions-link-rtl.png

CommentFileSizeAuthor
#14 Screen Shot 2021-07-02 at 9.33.04 am.png21.22 KBpameeela
#14 Screen Shot 2021-07-02 at 9.32.46 am.png5.1 KBpameeela
#14 Screen Shot 2021-07-02 at 9.32.22 am.png4.72 KBpameeela
#3 ltr-english.png64.35 KBtr
#3 rtl-english.png64.18 KBtr
demonstrate-block-regions-link-rtl.png4.27 KBJeff Burnz
block-module-rtl-demonstrate-block-regions-link.patch1.36 KBJeff Burnz

Comments

Jeff Burnz’s picture

Jeff Burnz commented
Status: Active » Needs review

I should say the screenshot was taken in Stark (not start...), sending to the bot.

aspilicious’s picture

aspilicious commented
Version: 7.x-dev » 8.x-dev
Status: Needs review » Reviewed & tested by the community

Found this thnx looks good and fixes rtl :).
Brakes strings so a no go for D7.

tr’s picture

tr commented
Component: block.module » language system
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new rtl-english.png64.18 KB
new ltr-english.png64.35 KB

Removing the parentheses is just avoiding one problem rather than finding and fixing the root cause. This artifact appears all over the interface, not just in the demonstrate block regions. For example see the attached images where I compare the language settings page in English LTR and RTL. You can see the same behavior with brackets and with periods too - the sentences are even broken up differently because of the problem with the periods. It's not even clear to me whether I *should* be seeing something sensible when I display a LTR language as RTL. Regardless, any fix should fix this in all locations, not just in once sentence on one page in one module.

good_man’s picture

good_man commented

This is absolutely not the solution. punctuation characters are called weak characters (they don't have direction information), that's why they appear out-of-context in RTL sentence.

The W3C page explains the possible solutions:
http://www.w3.org/International/tutorials/bidi-xhtml/#simplesolution

So we either enclose all punctuations with a directional tag, or use the invisible Unicode characters.

Note: translating the content to the targeted RTL language will solve this problem too, but it's still a bug.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

mcdruid’s picture

mcdruid commented
Issue summary: View changes

(switching text format for IS to avoid permissions problems)

pameeela’s picture

pameeela commented
Status: Needs work » Closed (cannot reproduce)
Issue tags: +Bug Smash Initiative
StatusFileSize
new Screen Shot 2021-07-02 at 9.32.22 am.png4.72 KB
new Screen Shot 2021-07-02 at 9.32.46 am.png5.1 KB
new Screen Shot 2021-07-02 at 9.33.04 am.png21.22 KB

Thanks mcdruid.

The examples here work well in Seven and Bartik now.