Steps to reproduce:
- Enable poll.module
- Enable the "Most recent poll" block
- Create a poll
=> The block doesn't contain the "Older polls" and "Results" links.

poll_block_latest_poll_view() does add these to $node->links – however, in poll_block_view() only $node->content is actually used. Since poll_block_latest_poll_view() isn't called anywhere else, I conclude that this is indeed unintended. The attached patch fixes this.

CommentFileSizeAuthor
#2 poll-block-links.patch768 bytesdrunken monkey
#1 Before patch, before vote8.69 KBeustace
#1 Before patch, after vote10.71 KBeustace
#1 After patch, before vote10.82 KBeustace
#1 After patch, after vote10.94 KBeustace
poll-block-links.patch649 bytesdrunken monkey

Comments

eustace’s picture

eustace commented
Status: Needs review » Needs work
StatusFileSize
new After patch, after vote10.94 KB
new After patch, before vote10.82 KB
new Before patch, after vote10.71 KB
new Before patch, before vote8.69 KB
  • Confirmed behavior as reported before applying patch and before voting
  • I see "Older polls" link appear before applying patch and after voting contrary to reported observation.
  • Both "Older polls" and "Results" links appear after applying patch and before voting as expected of the patch fix.
  • "Older polls" link appears twice after applying patch and after voting but no "Results" link.
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new poll-block-links.patch768 bytes

You're right, sorry. The result view already included the links. This patch only attaches them to the vote view.

eustace’s picture

eustace commented

New patch (poll-block-links_0.patch as depicted in test results) works as originally proposed. I agree with the change.

@drunken monkey, please link attachment in #2 to poll-block-links_0.patch for disambiguation. Propose rtbc after that. Thanks for the update.

+1

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

I can't edit the attachment link, sorry. Would have to repost the exact same patch, which seems a bit pointless. But I'll remember it in the future.
If you insist, I'd still do it, but otherwise please set to RTBC. Chances are, there will be re-rolls until the patch is committed, anyways …

eustace’s picture

eustace commented
Status: Needs review » Reviewed & tested by the community

Comments in #4 should be documentation enough for someone else reviewing later. Thanks for the fix. rtbc.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

#2: poll-block-links.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-dev » 8.x-dev

Although badly needed, this is D8 material according to the rules (I had to learn today). It may be backported at a later point in time (though that's unlikely).

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Version: 8.x-dev » 7.x-dev

It's a bug fix, with no API changes or anything remotely like that. Why should it be D8?

tom_o_t’s picture

tom_o_t commented

#2: poll-block-links.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.