This is a small step towards matching the UX designs from Kevin O'Leary

CommentFileSizeAuthor
display-toggle-switch.patch3.06 KBjames.elliott

Comments

james.elliott’s picture

james.elliott commented

Screenshots!

Before:
List
http://skitch.com/jameselliott/diq9f/content-d7-test

Grid
http://skitch.com/jameselliott/diq9e/content-d7-test

After:
List
http://skitch.com/jameselliott/diq64/content-d7-test

Grid
http://skitch.com/jameselliott/diq63/content-d7-test

effulgentsia’s picture

effulgentsia commented
Status: Needs review » Reviewed & tested by the community 
+++ javascript/media-admin.js	7 Sep 2010 14:55:54 -0000
@@ -42,7 +42,7 @@ Drupal.behaviors.mediaAdmin = {
-      .prependTo('.media-display-thumbnails')
+      .prependTo('#media-admin > div')

In general, I'd like us to move away from using id-based selectors like this. Because let's say some other module wants to output multiple instances of this form on a page, in which case, only the 1st one would have this ID.

But, we have lots of id-based selectors in the media module, so this is a future todo.

Otherwise, code and screenshots look great. Feel free to commit.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, display-toggle-switch.patch, failed testing.

james.elliott’s picture

james.elliott commented
Status: Needs work » Fixed

This was committed http://drupal.org/cvs?commit=417330

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.