Closed (outdated)
Project:
Drupal core
Version:
9.5.x-dev
Component:
other
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
8 Sep 2010 at 21:23 UTC
Updated:
11 Mar 2025 at 17:17 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedHere is the patch. It's my first core patch, so feedback is obviously appreciated.
Code for convince:
Comment #2
Anonymous (not verified) commentedI realized that
global $argsis redundant.New patch attached.
Comment #3
Anonymous (not verified) commentedAnd marking as "needs review"
Comment #4
Anonymous (not verified) commentedFixing an obvious bug in the way I had the string formatted.
Comment #5
Anonymous (not verified) commentedSorry. This takes practice, apparently.
Removing unnecessary junk from the top of the patch.
Comment #6
Anonymous (not verified) commentedAt Albright's suggestion, I added a \n to the second line in the if statement.
New patch up.
Comment #7
thedavidmeister commentedApparently run-tests.sh might be going away sometime soonish in the new CI setup, but for now this patch is still relevant to d8 and should be easy enough to port.
Comment #8
thedavidmeister commentedActually, looking at the patch again. I don't think there's any point showing a URL and saying "oh by the way, that URL is a 404". The warning message should show OR the info with the test ID should show. No reason to have both.
Comment #9
abhi170893 commentedthe attached patch applies cleanly to the 8.0.x
Comment #11
abhi170893 commentedreplaced the variable_get() with \Drupal::config()->get().
Comment #13
mile23run-tests.sh isn't going away any time soon.
run-tests.sh currently has a
--browseroption, which lets you see results in the browser.What else is needed?
Comment #23
quietone commentedIs this issue still a problem?
There has been no activity here for 5 years.
Since we need more information to move forward with this issue, I am keeping the status at Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Comment #26
smustgrave commentedSince there has been no follow up since requesting if this is still a feature 1 year ago (#23) going to close out
Thanks!