Comments

sun’s picture

Title: Make xmlrpc2 the first default server » Exclude xmlrpc1 in testing mode
StatusFileSize
new1.18 KB

Additionally accounting for redirects.

sun’s picture

Status: Needs review » Needs work

The last submitted patch, mollom-DRUPAL-6--1.testing-backend.2.patch, failed testing.

sun’s picture

Status: Needs work » Closed (won't fix)

I'm also still getting failures locally, even with this tweak. It looks like they may be caused by the SimpleTest installation routine, which probably invokes hook_requirements() and/or hook_install() prior to installing the module, or something like that.

At the very least, I've tried to debug this and make it work for a couple of hours, but I'm still getting communication errors from xmlrpc1.mollom.com, although it is totally enforced to be excluded with this patch.

In other words, I'm running out of ideas for workarounds that could be applied on the client-side.

sun’s picture

Status: Closed (won't fix) » Needs review
StatusFileSize
new1.42 KB

Obviously, I'm stupid. :P

sun’s picture

StatusFileSize
new3.98 KB

The problem is that this can still lead to failures, because the Mollom servers think that there are more servers that can be redirected to, but we're manually decreasing by one here, so there is still chance of hitting the maximum server refresh retries limit implemented in this patch. (I ran all tests manually and got one failing test due to the maximum of 3 refreshes being hit.)

sun’s picture

Status: Needs review » Closed (won't fix)

xmlrpc1 has been removed from the normal server list on the backend.

sun’s picture

Title: Exclude xmlrpc1 in testing mode » Remove xmlrpc1 from server list
Status: Closed (won't fix) » Reviewed & tested by the community
StatusFileSize
new863 bytes

However, we still get failing tests, since the initial request for mollom.getServerList fails.

sun’s picture

Status: Reviewed & tested by the community » Fixed

This massively hinders development, so I went ahead and committed this patch to HEAD and D6. Feel free to re-open this issue.

sun’s picture

Status: Fixed » Needs review
StatusFileSize
new850 bytes

Without the new backend in place, reverting this patch should break tests.

After the new backend has been deployed, this patch should pass.

Status: Needs review » Needs work

The last submitted patch, mollom-HEAD.xmlrpc1.9.patch, failed testing.

sun’s picture

Status: Needs work » Needs review

#10: mollom-HEAD.xmlrpc1.9.patch queued for re-testing.

sun’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
sun’s picture

#10: mollom-HEAD.xmlrpc1.9.patch queued for re-testing.

sun’s picture

Status: Needs review » Fixed

Reverted.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 58be5b5 on master, fai6, 8.x-2.x, fbajs, actions by sun:
    #906056 by sun: Reverted removal of xmlrpc1 from server list.
    
    
  • Commit 6fbe3df on master, fai6, 8.x-2.x, fbajs, actions by sun:
    #906056 by sun: Removed xmlrpc1 from server list.
    
    

  • Commit 58be5b5 on master, fai6, 8.x-2.x, fbajs, actions by sun:
    #906056 by sun: Reverted removal of xmlrpc1 from server list.
    
    
  • Commit 6fbe3df on master, fai6, 8.x-2.x, fbajs, actions by sun:
    #906056 by sun: Removed xmlrpc1 from server list.