Closed (fixed)
Project:
Mollom
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Sep 2010 at 22:41 UTC
Updated:
24 Apr 2014 at 17:13 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sunAdditionally accounting for redirects.
Comment #2
sunComment #4
sunI'm also still getting failures locally, even with this tweak. It looks like they may be caused by the SimpleTest installation routine, which probably invokes hook_requirements() and/or hook_install() prior to installing the module, or something like that.
At the very least, I've tried to debug this and make it work for a couple of hours, but I'm still getting communication errors from xmlrpc1.mollom.com, although it is totally enforced to be excluded with this patch.
In other words, I'm running out of ideas for workarounds that could be applied on the client-side.
Comment #5
sunObviously, I'm stupid. :P
Comment #6
sunThe problem is that this can still lead to failures, because the Mollom servers think that there are more servers that can be redirected to, but we're manually decreasing by one here, so there is still chance of hitting the maximum server refresh retries limit implemented in this patch. (I ran all tests manually and got one failing test due to the maximum of 3 refreshes being hit.)
Comment #7
sunxmlrpc1 has been removed from the normal server list on the backend.
Comment #8
sunHowever, we still get failing tests, since the initial request for mollom.getServerList fails.
Comment #9
sunThis massively hinders development, so I went ahead and committed this patch to HEAD and D6. Feel free to re-open this issue.
Comment #10
sunWithout the new backend in place, reverting this patch should break tests.
After the new backend has been deployed, this patch should pass.
Comment #12
sun#10: mollom-HEAD.xmlrpc1.9.patch queued for re-testing.
Comment #13
sunComment #14
sun#10: mollom-HEAD.xmlrpc1.9.patch queued for re-testing.
Comment #15
sunReverted.