Function _node_example_installed_fields() tries to set label for node_example_color, but fields do not contain label attribute according to http://api.drupal.org/api/group/field_structs/7.

Function _node_example_installed_instances() tries to set cardinality for node_example_color, but instances do not contain cardinality attribute according to http://api.drupal.org/api/group/field_structs/7.

CommentFileSizeAuthor
#2 examples.node_example_instance_parms.patch1.37 KBrfay

Comments

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Field Example is also broken, I assume due to the label change that just went in.

http://qa.drupal.org/pifr/test/26934

Would you be willing to roll a patch?

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Needs review
StatusFileSize
new examples.node_example_instance_parms.patch1.37 KB

Here's a patch to deal with this and a couple of other inconsistencies. Review appreciated.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

Committed to HEAD: http://drupal.org/cvs?commit=420878

Thanks so much for the report and careful reading. Any more of that you want to do is welcome around here. Patches too.

Also, HEAD is fixed now, by http://drupal.org/cvs?commit=420864

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.