Seeing this in IE8, probably the same in other browsers also, needs attention.

bartik-locale-select_list-too-wide.png

CommentFileSizeAuthor
#4 Mac-Chrome8-before.png53.21 KBbenjifisher
#4 Mac-FF3.6-before.png47.98 KBbenjifisher
#4 Mac-Safari5-before.png41.29 KBbenjifisher
#4 Mac-Chrome8-after.png53.56 KBbenjifisher
#4 Mac-FF3.6-after.png42.7 KBbenjifisher
#4 Mac-Safari5-after.png53.09 KBbenjifisher
#4 909440-bartik_locale_select_list_overflows_container-2.patch456 bytesbenjifisher
#3 909440-bartik_locale_select_list_overflows_container.patch406 bytesamateescu
#3 FF3.6-after.png14.31 KBamateescu
#3 IE8-after.png12.6 KBamateescu
#2 bartik-locale-select_list-too-wide-firefox.png19.61 KBJeff Burnz
bartik-locale-select_list-too-wide.png7.45 KBJeff Burnz

Comments

Jeff Burnz’s picture

Jeff Burnz commented

BTW - this is on the user profile Edit page with two sidebars enabled, I don't allow regular users to access the overlay (think that I want to display extra stuff to them in sidebars etc - a very normal scenario).

Jeff Burnz’s picture

Jeff Burnz commented
StatusFileSize
new bartik-locale-select_list-too-wide-firefox.png19.61 KB

In Firefox the select list forces its container wider, so this could definitely obscure sidebar content.

bartik-locale-select_list-too-wide-firefox.png

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new IE8-after.png12.6 KB
new FF3.6-after.png14.31 KB
new 909440-bartik_locale_select_list_overflows_container.patch406 bytes

Easy fix for this one, just add width: 100% to the locale select.

I targeted it with fieldset .form-item-timezone select and added this rule in the "Other overrides" section. Tested with IE 6,7,8, FF 3.6, Chrome, Opera on Windows 7 and XP.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
StatusFileSize
new 909440-bartik_locale_select_list_overflows_container-2.patch456 bytes
new Mac-Safari5-after.png53.09 KB
new Mac-FF3.6-after.png42.7 KB
new Mac-Chrome8-after.png53.56 KB
new Mac-Safari5-before.png41.29 KB
new Mac-FF3.6-before.png47.98 KB
new Mac-Chrome8-before.png53.21 KB

I tested the patch in #3 on my Mac: Chrome 8, Firefox 3.6, and Safari 5. I added enough blocks to the second sidebar so that there was overlap before applying the patch. I have attached before and after screenshots for all three browsers. I get basically the same results as in comment #3.

In Firefox (but not the others) the "Picture" fieldset above the "Locale settings" fieldset is three pixels too wide. I applied the same fix: see the attached patch.

amateescu’s picture

amateescu commented

#4: 909440-bartik_locale_select_list_overflows_container-2.patch queued for re-testing.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.