Locale select list overflows its container [#909440]

Seeing this in IE8, probably the same in other browsers also, needs attention.

Comment	File	Size	Author
#4	Mac-Chrome8-before.png	53.21 KB	benjifisher
#4	Mac-FF3.6-before.png	47.98 KB	benjifisher
#4	Mac-Safari5-before.png	41.29 KB	benjifisher
#4	Mac-Chrome8-after.png	53.56 KB	benjifisher
#4	Mac-FF3.6-after.png	42.7 KB	benjifisher
#4	Mac-Safari5-after.png	53.09 KB	benjifisher
#4	909440-bartik_locale_select_list_overflows_container-2.patch	456 bytes	benjifisher
#4
#3	909440-bartik_locale_select_list_overflows_container.patch	406 bytes	amateescu
#3
#3	FF3.6-after.png	14.31 KB	amateescu
#3	IE8-after.png	12.6 KB	amateescu
#2	bartik-locale-select_list-too-wide-firefox.png	19.61 KB	Jeff Burnz
	bartik-locale-select_list-too-wide.png	7.45 KB	Jeff Burnz

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Jeff Burnz CreditAttribution: Jeff Burnz commented 12 September 2010 at 20:09

BTW - this is on the user profile Edit page with two sidebars enabled, I don't allow regular users to access the overlay (think that I want to display extra stuff to them in sidebars etc - a very normal scenario).

Comment #2

Jeff Burnz CreditAttribution: Jeff Burnz commented 12 September 2010 at 20:26

File	Size
bartik-locale-select_list-too-wide-firefox.png	19.61 KB

In Firefox the select list forces its container wider, so this could definitely obscure sidebar content.

Comment #3

amateescu CreditAttribution: amateescu commented 23 January 2011 at 16:34

Status:

Active

» Needs review

File	Size
IE8-after.png	12.6 KB
FF3.6-after.png	14.31 KB
909440-bartik_locale_select_list_overflows_container.patch	406 bytes

Easy fix for this one, just add width: 100% to the locale select.

I targeted it with fieldset .form-item-timezone select and added this rule in the "Other overrides" section. Tested with IE 6,7,8, FF 3.6, Chrome, Opera on Windows 7 and XP.

Comment #4

benjifisher

he/him or they/them

English

Boston area

CreditAttribution: benjifisher commented 31 January 2011 at 16:28

File	Size
909440-bartik_locale_select_list_overflows_container-2.patch	456 bytes

Mac-Safari5-after.png	53.09 KB
Mac-FF3.6-after.png	42.7 KB
Mac-Chrome8-after.png	53.56 KB
Mac-Safari5-before.png	41.29 KB
Mac-FF3.6-before.png	47.98 KB
Mac-Chrome8-before.png	53.21 KB

I tested the patch in #3 on my Mac: Chrome 8, Firefox 3.6, and Safari 5. I added enough blocks to the second sidebar so that there was overlap before applying the patch. I have attached before and after screenshots for all three browsers. I get basically the same results as in comment #3.

In Firefox (but not the others) the "Picture" fieldset above the "Locale settings" fieldset is three pixels too wide. I applied the same fix: see the attached patch.