.

CommentFileSizeAuthor
#1 911104-media_all_none.patch4.49 KBJacobSingh

Comments

JacobSingh’s picture

JacobSingh commented
Status: Active » Needs review
StatusFileSize
new 911104-media_all_none.patch4.49 KB

I wonder how long this has been broken...

This was some pretty ugly JS. Anyway, it's not much prettier, but now only shows those links on the thumbnail page where they are required.

JacobSingh’s picture

JacobSingh commented

Patch looks a lot bigger than it is because cvs diff freaked out on the JS if block I added.

james.elliott’s picture

james.elliott commented

We could probably improve on the patch by not using an anonymous closure.

$('.media-display-thumbnails :checkbox').each(function () {
JacobSingh’s picture

JacobSingh commented

unrelated to the change at hand, but yes would be good to rewrite most of this JS.

JacobSingh’s picture

JacobSingh commented
Status: Needs review » Fixed

James okay'd this in chat.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.