Seven is trying to display a font called "normal Lucida Grande", which doesn't exist, so Lucida Sans Unicode is getting used instead. Fix is to move the weight to its proper position before the size.

Before:

  font: 81.3%/1.538em normal Lucida Grande, Lucida Sans Unicode, sans-serif;

After:

  font: normal 81.3%/1.538em Lucida Grande, Lucida Sans Unicode, sans-serif;

The difference is easiest to see on bold text; it's a little more crisp in Lucida Grande.

CommentFileSizeAuthor
#4 seven-font-fix-2.patch389 bytesmarkabur
seven-font-fix.patch385 bytesmarkabur

Comments

grendzy’s picture

grendzy commented
Status: Needs review » Reviewed & tested by the community

good catch.

mertskeli’s picture

mertskeli commented

If a font name contains white-space, it must be quoted.

So, the correct one is:
font: normal 81.3%/1.538em "Lucida Grande", "Lucida Sans Unicode", sans-serif;

(That was the reason for "normal Lucida Grande" behavior.
normal "Lucida Grande" would work correctly even if "normal" placed after font-size.
It is not the correct w3c order, but it works well because the other font properties have "normal" as the default values. Browsers recognise it and use it properly.)

jbrown’s picture

jbrown commented
Status: Reviewed & tested by the community » Needs work
markabur’s picture

markabur commented
Status: Needs work » Needs review
StatusFileSize
new seven-font-fix-2.patch389 bytes

normal "Lucida Grande" would work correctly even if "normal" placed after font-size.
It is not the correct w3c order, but it works well because the other font properties have "normal" as the default values. Browsers recognise it and use it properly.)

Actually that causes a parsing error in Firefox (using quotes with the wrong order). Safari's a little more lenient. In any case, revised patch is attached with correct ordering *and* quotes. Thanks!

mertskeli’s picture

mertskeli commented

I mainly spoke about IE. Although my FF3 (which I use as a secondary browser) did not show any errors... Ok, every browser is different, and of course it is always better to stick to standards.
Thanks. A good and useful UI bug catch.

Status: Needs review » Needs work

The last submitted patch, seven-font-fix-2.patch, failed testing.

markabur’s picture

markabur commented
Status: Needs work » Needs review

#4: seven-font-fix-2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, seven-font-fix-2.patch, failed testing.

markabur’s picture

markabur commented
Status: Needs work » Needs review

Hm, 2x "FAILED: [[SimpleTest]]: [MySQL] Setup environment: failed to drop checkout database." -- is this a problem with the patch, or with the testbot?

markabur’s picture

markabur commented

#4: seven-font-fix-2.patch queued for re-testing.

bleen’s picture

bleen commented
Status: Needs review » Reviewed & tested by the community

Green means go ...

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.