Closed (fixed)
Project:
D7 Media
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Sep 2010 at 18:01 UTC
Updated:
29 Sep 2010 at 15:16 UTC
Jump to comment: Most recent file
The padding around a thumbnail image that produces the whitespace between it and the border was declared using ems. Ems are only a relative unit when the font-size is adjusted. As the thumbnails themselves scale in size, the padding looks too large for small thumbnails and too small for large thumbnails. I've changed the padding to a percentage base so that the matte between the image and the border adjusts with the size of the thumbnail.
I also grouped the styles using CSSDOC @group comments for better organization.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 913764_thumbnail_padding_change_2.patch | 0 bytes | jessebeach |
| #1 | 913764_thumbnail_padding_change.patch | 1.06 KB | jessebeach |
Comments
Comment #1
jessebeach commentedOutdated, please ignore.
Comment #2
jessebeach commentedI removed padding from the image and left it with just width and height properties. The padding moves to the wrapper around the image and type icon (just video has an icon at the moment) to be consistent with how thumbnails are padded in non-overlay contexts.
Comment #3
james.elliott commentedPatch is empty
Comment #4
james.elliott commentedThis was committed as part of #915356: Various small CSS tweaks