locale.css loaded and applied on other pages and elements [#914194]

First identified here http://drupal.org/node/732914#comment-3455956

I'm having a very hard time figuring out how to reproduce this - but it just seems that *sometimes* locale.css loads for this path.

Right now in Drupal this has no discernible affect on the exposed filters at admin/content because other CSS overrides locale.css, however if we apply the patch from #732914: Improve the markup/CSS for content and user filter forms those overrides are removed and if locale.css loads it messes up the filters.

From what I can tell locale.css should not be loading on this page so I is this a bug?

I'm attaching a screenshot - this taken before the #732914 patch, you can clearly see locale.css is loading but being overriden by other CSS (node and user css actually).

Comment	File	Size	Author
#5	locale.css_.png	10.53 KB	sun
#5	drupal.locale-css.5.patch	1.06 KB	sun
	locale-form-item2.png	51.44 KB	Jeff Burnz

Comments

Comment #1

sun

German

Karlsruhe

commented 17 September 2010 at 02:19

subscribing

Comment #2

jacine

she/her

New York

commented 17 September 2010 at 04:07

File issue aside, I think this CSS is potentially problematic because the field names are very generic:

.form-item-language,
.form-item-translation,
.form-item-group {
  ...
}

This seems safer, and actually more efficient, minus the fact that it's using an ID as opposed to a class:

#locale-translation-filter-form .form-item {
  ...
}

Comment #3

jacine

she/her

New York

commented 17 September 2010 at 04:10

Looking at the rest of the CSS in that file, it also makes more sense in the context of the existing code to use the ID: http://drupalcode.org/viewvc/drupal/drupal/modules/locale/locale.css?&vi...