Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Whoa. We have testbot running on this project! When did that happen? I don't think the failure is related to this patch though. I committed the patch, as it's a no-brainer.
Why don't we get rid of the big provider icons all together and just use fav icons for each provider? We can also show each provider using a vertical accordion. When you click on a provider name it would expand to show the usage examples.
Here's the code I had locally with a little bit cleaner output and removes the CSS from media.css. If we want to re-add it it should be going in media_internet.css and not the base CSS.
Comments
Comment #2
effulgentsia CreditAttribution: effulgentsia commentedWhoa. We have testbot running on this project! When did that happen? I don't think the failure is related to this patch though. I committed the patch, as it's a no-brainer.
Comment #4
Jon PughThose icons drive me batty. Why are they even sprites, anyway? They aren't linked...
Here's a lame patch that crops the images with CSS and goes ahead and adds :hover positioning for these non-links.
If we don't want this, we should just change those images to not be sprites?
Comment #5
gmclelland CreditAttribution: gmclelland commentedWhy don't we get rid of the big provider icons all together and just use fav icons for each provider? We can also show each provider using a vertical accordion. When you click on a provider name it would expand to show the usage examples.
See #1494416: UX - Providers - List Usage Examples
Comment #6
Devin Carlson CreditAttribution: Devin Carlson commentedMarked #1494416: UX - Providers - List Usage Examples and #1261396: 'Supported providers' list styling as duplicates.
Comment #7
Dave ReidI'd rather just use text for the providers at this point. This has been horribly broken for so long.
Comment #8
Devin Carlson CreditAttribution: Devin Carlson commentedA patch to convert the display of providers into an unordered list of provider titles per #7.
I haven't removed
'image'
frommedia_internet.api.php
but that could be done if required.Comment #9
Dave ReidHere's the code I had locally with a little bit cleaner output and removes the CSS from media.css. If we want to re-add it it should be going in media_internet.css and not the base CSS.
Comment #10
Dave ReidWith the CSS removal.
Comment #11
Dave ReidWith a nice class for each list item so that it can be styled by individual modules.
Comment #12
Dave ReidHere's how it looks with the patch in #11.
Comment #13
Dave ReidThis would also make it possible to do something like this:
which would look like:
Comment #14
Dave ReidCommitted #11 to both branches:
http://drupalcode.org/project/media.git/commit/1abf00d
http://drupalcode.org/project/media.git/commit/6601dbe