Closed (fixed)
Project:
D7 Media
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
18 Sep 2010 at 02:49 UTC
Updated:
10 Apr 2012 at 21:40 UTC
Jump to comment: Most recent file
See patch.
Comments
Comment #2
effulgentsia commentedWhoa. We have testbot running on this project! When did that happen? I don't think the failure is related to this patch though. I committed the patch, as it's a no-brainer.
Comment #4
jon pughThose icons drive me batty. Why are they even sprites, anyway? They aren't linked...
Here's a lame patch that crops the images with CSS and goes ahead and adds :hover positioning for these non-links.
If we don't want this, we should just change those images to not be sprites?
Comment #5
gmclelland commentedWhy don't we get rid of the big provider icons all together and just use fav icons for each provider? We can also show each provider using a vertical accordion. When you click on a provider name it would expand to show the usage examples.
See #1494416: UX - Providers - List Usage Examples
Comment #6
devin carlson commentedMarked #1494416: UX - Providers - List Usage Examples and #1261396: 'Supported providers' list styling as duplicates.
Comment #7
dave reidI'd rather just use text for the providers at this point. This has been horribly broken for so long.
Comment #8
devin carlson commentedA patch to convert the display of providers into an unordered list of provider titles per #7.
I haven't removed
'image'frommedia_internet.api.phpbut that could be done if required.Comment #9
dave reidHere's the code I had locally with a little bit cleaner output and removes the CSS from media.css. If we want to re-add it it should be going in media_internet.css and not the base CSS.
Comment #10
dave reidWith the CSS removal.
Comment #11
dave reidWith a nice class for each list item so that it can be styled by individual modules.
Comment #12
dave reidHere's how it looks with the patch in #11.
Comment #13
dave reidThis would also make it possible to do something like this:
which would look like:
_0.png)
Comment #14
dave reidCommitted #11 to both branches:
http://drupalcode.org/project/media.git/commit/1abf00d
http://drupalcode.org/project/media.git/commit/6601dbe