Closed (duplicate)
Project:
Drupal core
Version:
7.x-dev
Component:
database system
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
19 Sep 2010 at 15:47 UTC
Updated:
19 Sep 2010 at 16:20 UTC
Jump to comment: Most recent file
So, chx and I have been working on adding pager support to EntityFieldQuery (#885014: Add pager and tablesort to EntityFieldQuery).
We've decided to skip the sql pager in order to make the code reusable for non-sql field storage.
However, we need to access (and modify) PagerDefault::$maxElement in order not to overlap with any existing (non-EFQ) pagers on the page.
That causes a fatal error because $maxElement is protected. I want to make it public. Any objections / downsides I'm not thinking of?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 916278.patch | 344 bytes | bojanz |
| #1 | 916278.patch | 344 bytes | bojanz |
Comments
Comment #1
bojanz commentedSimple patch.
Comment #2
bojanz commentedchx said we can tackle this in the original issue. No need to open another one.
Comment #3
bojanz commentedAnd btw, the patch was wrong :P