So, chx and I have been working on adding pager support to EntityFieldQuery (#885014: Add pager and tablesort to EntityFieldQuery).
We've decided to skip the sql pager in order to make the code reusable for non-sql field storage.
However, we need to access (and modify) PagerDefault::$maxElement in order not to overlap with any existing (non-EFQ) pagers on the page.
That causes a fatal error because $maxElement is protected. I want to make it public. Any objections / downsides I'm not thinking of?

CommentFileSizeAuthor
#2 916278.patch344 bytesbojanz
#1 916278.patch344 bytesbojanz

Comments

bojanz’s picture

Status: Active » Needs review
StatusFileSize
new344 bytes

Simple patch.

bojanz’s picture

Status: Needs review » Closed (duplicate)
StatusFileSize
new344 bytes

chx said we can tackle this in the original issue. No need to open another one.

bojanz’s picture

And btw, the patch was wrong :P