At the moment we don't enforce uniqueness we need too.

CommentFileSizeAuthor
#12 services-916642.patch1.12 KBkylebrowning
#9 services-916642.patch1.12 KBkylebrowning
#7 services-916642.patch1.12 KBkylebrowning
#4 services-916642.patch1.11 KBkylebrowning
#2 services-916642.patch1.1 KBkylebrowning

Comments

kylebrowning’s picture

kylebrowning commented
Assigned: marcingy » kylebrowning

Ill fix this.

kylebrowning’s picture

kylebrowning commented
Status: Active » Needs review
StatusFileSize
new services-916642.patch1.1 KB

attached is the patch.

marcingy’s picture

marcingy commented
Status: Needs review » Needs work

Can we pass this through t()

  form_set_error('domain', 'Domain "'. $values['domain'] . '" already exists.');

Plus why not do this

$domain = $form_state['values']['domain'];

kylebrowning’s picture

kylebrowning commented
Status: Needs work » Needs review
StatusFileSize
new services-916642.patch1.11 KB

Re-rolled patch with changes suggested in #3

marcingy’s picture

marcingy commented
Status: Needs work » Needs review

The t() call should utilse string replacement placeholders rather than concatenating the value directly.

t('Domain @domain already exists.', array('@domain' => $domain));
marcingy’s picture

marcingy commented
Status: Needs review » Needs work
kylebrowning’s picture

kylebrowning commented
Status: Needs review » Needs work
StatusFileSize
new services-916642.patch1.12 KB

Re-rolled patch according to #5

kylebrowning’s picture

kylebrowning commented
Status: Needs work » Needs review

Setting to needs review for simpletest

kylebrowning’s picture

kylebrowning commented
StatusFileSize
new services-916642.patch1.12 KB

Updated patch for mistake.

marcingy’s picture

marcingy commented 
form_set_error('domain', t('Domain @domain already exists.', array('@domain', $domain)));

should be

form_set_error('domain', t('Domain @domain already exists.', array('@domain' => $domain)));

Then I think this is good to go.

Kyle thanks for tackling this.

kylebrowning’s picture

kylebrowning commented

Woops sorry was trying to finish it before gorillaz ill
Fix it tomorrow

kylebrowning’s picture

kylebrowning commented
StatusFileSize
new services-916642.patch1.12 KB

ok, here we go.

marcingy’s picture

marcingy commented
Status: Needs review » Reviewed & tested by the community

Looks good.

kylebrowning’s picture

kylebrowning commented
Status: Reviewed & tested by the community » Fixed

This has been fixed and commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.