Changing quality field to float from varchar throws error when the field has no value

Looks ok to me - guess mysql doesn't know how to cast empty string to float.

doesn't matter (PDO casts to string), but I might use '0' vs. 0

also, why LIKE '', versus = '' ?

Yeah I'm not sure why the 'LIKE' condition is needed compared to a direct comparison.

How about this?

mmm... actually, that's a very good point. We want the resulting value to become NULL instead. Real 'quality' values are ranging from 0 to 1. So I wonder whether we can temporarily update to a 2 or 9 for empty strings, and after converting to float, set those rows to NULL. Hrm. Any better ideas?

quality is in an alpha/beta thing so we can reset those values to 0 if that is easier. None of the module code actually uses the value.

Really not sure whether there is a better way of doing this. But here's how it could work.

I have manually installed alpha1, created some form protections and imported some {mollom} data, and all updates ran fine with this patch and led to the expected values. While doing so, I realized that update.php also displays the phpDoc description of an update... so I additionally tweaked that description a bit.

Another tweak for the description.

Code looks good but not in a position to test it right now. Sun can commit the patch if it is properly tested.

I'd also be happy to drop the quality column for the time being.

Thanks for reporting, reviewing, and testing! Committed to HEAD.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.