When plupload is enabled in the media browser, sometimes the tab gets cut off. This is because Drupal.media.browser.resizeIframe is getting called before the plupload JS has had time to expand all its elements. This is happening right now in IE but could easily happen in other browsers as well.

CommentFileSizeAuthor
#6 media.upload_multiple.js_.txt618 bytesJacobSingh
#1 917684-1-plupload-cut-off.patch2.4 KBksenzee

Comments

ksenzee’s picture

ksenzee
she/her
commented
Status: Active » Needs review
StatusFileSize
new 917684-1-plupload-cut-off.patch2.4 KB

It would be great to get a review on this before commit. I added media.upload_multiple.js to javascript/plugins, and I'm not sure if that's where we're currently putting JS for media browser tabs.

james.elliott’s picture

james.elliott commented
Status: Needs review » Fixed

This is great, committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Scott J’s picture

Scott J commented
Status: Closed (fixed) » Active

I'm still seeing this problem in the latest dev. If I select tabs 'Web' or 'Library' then come back to 'Upload' it is fixed.

james.elliott’s picture

james.elliott commented
Assigned: ksenzee » james.elliott
JacobSingh’s picture

JacobSingh commented
Status: Active » Needs review
StatusFileSize
new media.upload_multiple.js_.txt618 bytes

I think this was an oversight where this file was never added to CVS.
Committed now, please test and mark fixed.

james.elliott’s picture

james.elliott commented
Status: Needs review » Fixed

Works as intended

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

alienzed’s picture

alienzed commented

On a fresh install this problem still exists, enabling Media Internet Sources module fixes it though... Basically when there is a single tab, the Start Upoad and Cancel button are hidden and you can't scroll to them either...