Closed (fixed)
Project:
Storm
Version:
6.x-1.x-dev
Component:
Storm Timetracking
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
21 Sep 2010 at 22:32 UTC
Updated:
2 Jun 2011 at 00:22 UTC
Jump to comment: Most recent file
We need tests for Storm Timetracking
| Comment | File | Size | Author |
|---|---|---|---|
| #40 | storm-tt-tests-1.x.patch | 9.86 KB | juliangb |
| #39 | storm--tt-test3.patch | 9.6 KB | juliangb |
| #35 | storm--tt-test3.patch | 9.6 KB | juliangb |
| #33 | storm--tt-tests2.patch | 5.89 KB | juliangb |
| #31 | storm--tt-tests.patch | 2.12 KB | juliangb |
Comments
Comment #1
juliangb commentedComment #3
juliangb commentedComment #5
juliangb commentedComment #6
juliangb commentedI will commit this in a few days unless anyone comments with a reason not to.
Comment #7
juliangb commentedtchurch, would you mind committing this one please?
Comment #8
juliangb commented#5: storm--918750-5.patch queued for re-testing.
Just noticed that the test results for the latest patch only showed one assertion for the new test.
Comment #9
juliangb commentedNot sure whether this is OK or not.
On the one hand, there are no exceptions or test failures, but on the other hand, there should be a number more test passes.
Comment #10
juliangb commented#5: storm--918750-5.patch queued for re-testing.
Comment #12
juliangb commented#5: storm--918750-5.patch queued for re-testing.
Comment #14
juliangb commentedPatch for testbot.
Not complete - checking where the test aborts.
Comment #16
juliangb commentedAgain, trying to find where the test aborts.
Comment #18
juliangb commentedEntire test commented out.
Comment #19
juliangb commentedCorrected comment brackets.
Comment #21
rjgoldsborough commentedI am working on this test, and had a question. I didn't notice it before but when creating a project, you do not have to specify an organization. But when creating a task you do. It doesn't make sense as you could create a project without an organization, but then you would not be able to create a task for that project without first creating an organization. Then in the timetrack code, where the project list is generated, there is an sql query involving an organization id. This is bad because you would only get projects that have an organization, which isn't required. So this seems to limit the timetrack node quite a bit.
Also a little off topic, but I want to bring it up as I just saw it.
So it seems like the requirements on some of these are a bit off.
It looks as if you could create a project with no organization, and then try to create a ticket for that project without success as it requires an organization that the project may or not be a part of. (seems similar to the task situation above)
Ok, that's all for now. (I could just be overthinking this, but it seems to make sense to me heh)
Comment #22
juliangb commentedIt is definitely a bug if any module does not perform totally with only the minimum required modules enabled.
Comment #23
juliangb commentedReroll. Also needs review as its been a while since I've looked at this.
Comment #24
juliangb commentedComment #26
juliangb commentedComment #27
juliangb commented#24: storm--918750-23.patch queued for re-testing.
Comment #29
juliangb commented#24: storm--918750-23.patch queued for re-testing.
Comment #31
juliangb commentedJust a patch with the tests.
Comment #33
juliangb commentedComment #35
juliangb commentedComment #36
juliangb commentedCommitted to 2.x.
Retest on 1.x.
Comment #37
juliangb commented#35: storm--tt-test3.patch queued for re-testing.
Comment #38
juliangb commentedComment #39
juliangb commentedComment #40
juliangb commentedComment #41
juliangb commentedCommitted to 1.x.